Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2755513002: [DevTools] rebased tests for V8 roll (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] rebased tests for V8 roll V8 roll will update stepping between tasks behavior and makes it just better. BUG=chromium:701500 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2755513002 Cr-Commit-Position: refs/heads/master@{#458655} Committed: https://chromium.googlesource.com/chromium/src/+/84290e6b3e01da65bc08ddf240771959083fbee4

Patch Set 1 #

Patch Set 2 : better! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/pause-on-elements-panel-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-across-timeouts-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-document-write.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-document-write-expected.txt View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-inlined-scripts-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-across-timeouts-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-custom-element-callbacks.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-custom-element-callbacks-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-document-write-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-out-event-listener-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-across-timeouts-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-document-write.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-document-write-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-inlined-scripts-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
kozy
Dmitry, please take a look. It's preparation for rolling https://codereview.chromium.org/2748503002/.
3 years, 9 months ago (2017-03-14 20:03:54 UTC) #1
dgozman
> Only one use case was changed: stepOut from one event listener will just make ...
3 years, 9 months ago (2017-03-14 21:31:04 UTC) #5
kozy
On 2017/03/14 21:31:04, dgozman wrote: > > Only one use case was changed: stepOut from ...
3 years, 9 months ago (2017-03-14 21:36:41 UTC) #6
dgozman
On 2017/03/14 21:36:41, kozy wrote: > On 2017/03/14 21:31:04, dgozman wrote: > > > Only ...
3 years, 9 months ago (2017-03-14 21:48:27 UTC) #7
kozy
Done, please take a look on new expectations :)
3 years, 9 months ago (2017-03-20 23:00:46 UTC) #11
dgozman
lgtm
3 years, 9 months ago (2017-03-21 22:33:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755513002/20001
3 years, 9 months ago (2017-03-22 03:56:15 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 05:57:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755513002/20001
3 years, 9 months ago (2017-03-22 06:12:33 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 07:06:51 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/84290e6b3e01da65bc08ddf24077...

Powered by Google App Engine
This is Rietveld 408576698