Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: components/metrics/proto/omnibox_event.proto

Issue 2755503002: Add a new entry to omnibox_event.proto to log specific type of contextual suggestions (Closed)
Patch Set: Moved the logging of the specific type in the omnibox_event proto. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/proto/omnibox_event.proto
diff --git a/components/metrics/proto/omnibox_event.proto b/components/metrics/proto/omnibox_event.proto
index 0410d6cc0edfd97b55f6d4b7dec11a15de84dcee..5b9e9af368e523038592da5689bbbc70e995f7d1 100644
--- a/components/metrics/proto/omnibox_event.proto
+++ b/components/metrics/proto/omnibox_event.proto
@@ -177,7 +177,7 @@ message OmniboxEventProto {
}
// The result set displayed on the completion popup
- // Next tag: 7
+ // Next tag: 8
message Suggestion {
// Where does this result come from?
optional ProviderType provider = 1;
@@ -253,6 +253,10 @@ message OmniboxEventProto {
// Whether this item is disabled in the UI (not clickable).
optional bool is_disabled = 6;
+
+ // This is an integer that is used to identify the type of a contextual
+ // suggestion provided through zero-suggest.
Mark P 2017/03/20 21:51:43 Please use more generic language, because we want
gcomanici 2017/03/21 19:23:48 Done.
+ optional int32 specific_type_identifier = 7;
}
repeated Suggestion suggestion = 9;
« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | components/omnibox/browser/autocomplete_match.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698