Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: components/metrics/proto/omnibox_event.proto

Issue 2755503002: Add a new entry to omnibox_event.proto to log specific type of contextual suggestions (Closed)
Patch Set: Moved the logging of the specific type in the omnibox_event proto. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about an omnibox interaction. 5 // Stores information about an omnibox interaction.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 option java_outer_classname = "OmniboxEventProtos"; 10 option java_outer_classname = "OmniboxEventProtos";
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 ON_DEVICE = 12; 170 ON_DEVICE = 12;
171 // This enum value is currently only used by Android GSA. It represents 171 // This enum value is currently only used by Android GSA. It represents
172 // a suggestion powered by a Chrome content provider. 172 // a suggestion powered by a Chrome content provider.
173 ON_DEVICE_CHROME = 13; 173 ON_DEVICE_CHROME = 13;
174 CLIPBOARD_URL = 14; // Suggestion coming from clipboard (iOS only). 174 CLIPBOARD_URL = 14; // Suggestion coming from clipboard (iOS only).
175 PHYSICAL_WEB = 15; // Suggestions triggered by URLs broadcast by nearby 175 PHYSICAL_WEB = 15; // Suggestions triggered by URLs broadcast by nearby
176 // devices (iOS and Android). 176 // devices (iOS and Android).
177 } 177 }
178 178
179 // The result set displayed on the completion popup 179 // The result set displayed on the completion popup
180 // Next tag: 7 180 // Next tag: 8
181 message Suggestion { 181 message Suggestion {
182 // Where does this result come from? 182 // Where does this result come from?
183 optional ProviderType provider = 1; 183 optional ProviderType provider = 1;
184 184
185 // What kind of result this is. 185 // What kind of result this is.
186 // This corresponds to the AutocompleteMatch::Type enumeration in 186 // This corresponds to the AutocompleteMatch::Type enumeration in
187 // components/omnibox/autocomplete_match.h (except for Android 187 // components/omnibox/autocomplete_match.h (except for Android
188 // GSA result types). 188 // GSA result types).
189 enum ResultType { 189 enum ResultType {
190 UNKNOWN_RESULT_TYPE = 0; // Unknown type (should not reach here) 190 UNKNOWN_RESULT_TYPE = 0; // Unknown type (should not reach here)
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 // Only set for some providers and result_types. At the time of 246 // Only set for some providers and result_types. At the time of
247 // writing this comment, it is only set for HistoryURL and 247 // writing this comment, it is only set for HistoryURL and
248 // HistoryQuickProvider matches. 248 // HistoryQuickProvider matches.
249 optional int32 typed_count = 5; 249 optional int32 typed_count = 5;
250 250
251 // Whether this item is starred (bookmarked) or not. 251 // Whether this item is starred (bookmarked) or not.
252 optional bool is_starred = 4 [deprecated=true]; 252 optional bool is_starred = 4 [deprecated=true];
253 253
254 // Whether this item is disabled in the UI (not clickable). 254 // Whether this item is disabled in the UI (not clickable).
255 optional bool is_disabled = 6; 255 optional bool is_disabled = 6;
256
257 // This is an integer that is used to identify the type of a contextual
258 // suggestion provided through zero-suggest.
Mark P 2017/03/20 21:51:43 Please use more generic language, because we want
gcomanici 2017/03/21 19:23:48 Done.
259 optional int32 specific_type_identifier = 7;
256 } 260 }
257 repeated Suggestion suggestion = 9; 261 repeated Suggestion suggestion = 9;
258 262
259 // A data structure that holds per-provider information, general information 263 // A data structure that holds per-provider information, general information
260 // not associated with a particular result. 264 // not associated with a particular result.
261 // Next tag: 6 265 // Next tag: 6
262 message ProviderInfo { 266 message ProviderInfo {
263 // Which provider generated this ProviderInfo entry. 267 // Which provider generated this ProviderInfo entry.
264 optional ProviderType provider = 1; 268 optional ProviderType provider = 1;
265 269
(...skipping 21 matching lines...) Expand all
287 // The number of times this provider returned a non-zero number of 291 // The number of times this provider returned a non-zero number of
288 // suggestions during this omnibox session. 292 // suggestions during this omnibox session.
289 // Note that each provider may define a session differently for its 293 // Note that each provider may define a session differently for its
290 // purposes. 294 // purposes.
291 optional int32 times_returned_results_in_session = 5; 295 optional int32 times_returned_results_in_session = 5;
292 } 296 }
293 // A list of diagnostic information about each provider. Providers 297 // A list of diagnostic information about each provider. Providers
294 // will appear at most once in this list. 298 // will appear at most once in this list.
295 repeated ProviderInfo provider_info = 12; 299 repeated ProviderInfo provider_info = 12;
296 } 300 }
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | components/omnibox/browser/autocomplete_match.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698