third_party/WebKit/Source/core/css/CSSViewportRule.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSViewportRule.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSViewportRule.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSViewportRule.cpp b/third_party/WebKit/Source/core/css/CSSViewportRule.cpp

index e1b0e8ef5de91b2cb3bc9178f33f07edf81c8de3..72baa4b230d6a0a91359d1023d7ba4cc89f11a46 100644

--- a/third_party/WebKit/Source/core/css/CSSViewportRule.cpp

+++ b/third_party/WebKit/Source/core/css/CSSViewportRule.cpp

@@ -67,7 +67,7 @@ String CSSViewportRule::cssText() const {

}

void CSSViewportRule::reattach(StyleRuleBase* rule) {

- ASSERT(rule);

+ DCHECK(rule);

m_viewportRule = toStyleRuleViewport(rule);

if (m_propertiesCSSOMWrapper)

m_propertiesCSSOMWrapper->reattach(m_viewportRule->mutableProperties());