Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/CSSProperty.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)
Patch Set: Worked on Review Comments done Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp ('K') | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp » ('j') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSProperty.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSProperty.cpp b/third_party/WebKit/Source/core/css/CSSProperty.cpp
index df821c4ffe2b6334866e693cf65c48ca854e82b2..6090963cee59f073a807a5c34e96e3730ad933c0 100644
--- a/third_party/WebKit/Source/core/css/CSSProperty.cpp
+++ b/third_party/WebKit/Source/core/css/CSSProperty.cpp
@@ -40,8 +40,9 @@ CSSPropertyID StylePropertyMetadata::shorthandID() const {
Vector<StylePropertyShorthand, 4> shorthands;
getMatchingShorthandsForLonghand(static_cast<CSSPropertyID>(m_propertyID),
&shorthands);
- ASSERT(shorthands.size() && m_indexInShorthandsVector >= 0 &&
- m_indexInShorthandsVector < shorthands.size());
+ DCHECK(shorthands.size());
+ DCHECK_GE(m_indexInShorthandsVector, static_cast<unsigned>(0));
tkent 2017/03/28 14:44:55 static_cast<unsigned>(0) -> 0u
nikhil.sahni 2017/03/30 12:17:57 Done.
+ DCHECK_LT(m_indexInShorthandsVector, shorthands.size());
return shorthands.at(m_indexInShorthandsVector).id();
}
« third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp ('K') | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp » ('j') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698