third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h

diff --git a/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h b/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h

index f711dff8748f382f3799a427cc0a520075ebb280..7695af7e9a2a28a40fad9ea5dc35983d7ecb77f4 100644

--- a/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h

+++ b/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h

@@ -51,7 +51,7 @@ class CSSCustomPropertyDeclaration : public CSSValue {

m_name(name),

m_value(nullptr),

m_valueId(id) {

- ASSERT(id == CSSValueInherit || id == CSSValueInitial ||

+ DCHECK(id == CSSValueInherit || id == CSSValueInitial ||

id == CSSValueUnset);

}