third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp - Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

Issue 2755493004: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ (Closed)

Patch Set: Worked on Review Comments done Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

index f6ad4aff9cc2e7f3b47b59f18b6f8417762b13c3..087dfc3837c2824df8266c4827cc1e5c9281509c 100644

--- a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

@@ -17,7 +17,7 @@ CSSCustomIdentValue::CSSCustomIdentValue(const AtomicString& str)

CSSCustomIdentValue::CSSCustomIdentValue(CSSPropertyID id)

: CSSValue(CustomIdentClass), m_string(), m_propertyId(id) {

- ASSERT(isKnownPropertyID());

+ DCHECK(isKnownPropertyID());

}

String CSSCustomIdentValue::customCSSText() const {