Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2755483007: DevTools: wire network requests to async infrastructure to test coverage. (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: wire network requests to async infrastructure to test coverage. BUG=701177 Review-Url: https://codereview.chromium.org/2755483007 Cr-Commit-Position: refs/heads/master@{#457324} Committed: https://chromium.googlesource.com/chromium/src/+/75609e13c825b3783c782ad0559d5c603d04d82d

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : compiles #

Patch Set 4 : win compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 2 3 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 2 3 5 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
pfeldman
Hey, caseq, how do i do it right?
3 years, 9 months ago (2017-03-15 06:58:11 UTC) #2
caseq
lgtm
3 years, 9 months ago (2017-03-15 20:46:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755483007/40001
3 years, 9 months ago (2017-03-15 22:41:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/385138)
3 years, 9 months ago (2017-03-15 23:11:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755483007/60001
3 years, 9 months ago (2017-03-16 01:12:51 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:34:45 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/75609e13c825b3783c782ad0559d...

Powered by Google App Engine
This is Rietveld 408576698