Stop having separate timeout timers for the preflight and the actual request

Stop having separate timeout timers for the preflight and the actual request

DocumentThreadableLoader stops the timeout timer and restarts it with fresh
timeout when getting a preflight response and sending the actual request. This
fixes it so that the timeout is applied to the combined request, not to each of
the preflight and the actual request.

BUG=699985
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2755483006
Cr-Commit-Position: refs/heads/master@{#459728}
Committed: https://chromium.googlesource.com/chromium/src/+/a299a05414fc647524bf1da64fa2b058e5915d69

[yhirano, 2017-03-15 01:28:52]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 01:29:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-03-15 01:49:41]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 01:50:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-03-15 02:27:13]

PTAL

The layout test is similar to (part of)
https://github.com/w3c/web-platform-tests/blob/master/XMLHttpRequest/timeout-....
I'm not sure if we should have this test or we can rely on the web platform
test.

[commit-bot: I haz the power, 2017-03-15 03:35:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 03:35:55]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2017-03-15 15:42:46]

IIRC, we shouldn't add a new Perl file. Could you please use some existing php
file or create one?

[yhirano, 2017-03-21 07:30:08]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 07:30:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-03-21 07:30:55]

On 2017/03/15 15:42:46, tyoshino wrote:
> IIRC, we shouldn't add a new Perl file. Could you please use some existing php
> file or create one?

Fixed.

[commit-bot: I haz the power, 2017-03-21 09:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 09:24:07]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-03-24 03:46:37]

On 2017/03/21 07:30:55, yhirano wrote:
> On 2017/03/15 15:42:46, tyoshino wrote:
> > IIRC, we shouldn't add a new Perl file. Could you please use some existing
php
> > file or create one?
> 
> Fixed.

ping

[tyoshino (SeeGerritForStatus), 2017-03-27 04:58:14]

lgtm

[yhirano, 2017-03-27 05:00:50]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-03-27 05:01:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 06:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 06:06:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2017-03-27 07:02:22]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-03-27 07:02:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 09:12:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490598142569530,
"parent_rev": "588a32ac7a5824a30aea437bf85a1f7615dfcbc3", "commit_rev":
"a299a05414fc647524bf1da64fa2b058e5915d69"}

[commit-bot: I haz the power, 2017-03-27 09:13:36]

Description was changed from

==========
Stop having separate timeout timers for the preflight and the actual request

DocumentThreadableLoader stops the timeout timer and restarts it with fresh
timeout when getting a preflight response and sending the actual request. This
fixes it so that the timeout is applied to the combined request, not to each of
the preflight and the actual request.

BUG=699985
R=tyoshino@chromium.org
==========

to

==========
Stop having separate timeout timers for the preflight and the actual request

DocumentThreadableLoader stops the timeout timer and restarts it with fresh
timeout when getting a preflight response and sending the actual request. This
fixes it so that the timeout is applied to the combined request, not to each of
the preflight and the actual request.

BUG=699985
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2755483006
Cr-Commit-Position: refs/heads/master@{#459728}
Committed:
https://chromium.googlesource.com/chromium/src/+/a299a05414fc647524bf1da64fa2...
==========

[commit-bot: I haz the power, 2017-03-27 09:13:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a299a05414fc647524bf1da64fa2...