Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2755483005: Revert icon to unmodified state (Closed)

Created:
3 years, 9 months ago by jasonkliu
Modified:
3 years, 9 months ago
Reviewers:
mrefaat, Evan Stade
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert icon to unmodified state BUG=701363 Review-Url: https://codereview.chromium.org/2755483005 Cr-Commit-Position: refs/heads/master@{#458430} Committed: https://chromium.googlesource.com/chromium/src/+/30d9c1420d887d155f3c4fcbf7011c1e56b922a8

Patch Set 1 #

Patch Set 2 : Icon is for Windows only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/app/vector_icons/BUILD.gn View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/app/vector_icons/open_in_phone.icon View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jasonkliu
PTAL, thanks! Here is the result of the icon change: https://drive.google.com/open?id=0B3dPCXKQYa2ddlBjZDEzbHRTek0 The top image is ...
3 years, 9 months ago (2017-03-15 00:54:42 UTC) #2
Evan Stade
On 2017/03/15 00:54:42, jasonkliu1 wrote: > PTAL, thanks! > > Here is the result of ...
3 years, 9 months ago (2017-03-15 15:37:40 UTC) #3
mrefaat
lgtm
3 years, 9 months ago (2017-03-15 15:39:04 UTC) #4
Evan Stade
On 2017/03/15 15:37:40, Evan Stade wrote: > On 2017/03/15 00:54:42, jasonkliu1 wrote: > > PTAL, ...
3 years, 9 months ago (2017-03-15 15:39:28 UTC) #5
jasonkliu
On 2017/03/15 15:39:28, Evan Stade wrote: > On 2017/03/15 15:37:40, Evan Stade wrote: > > ...
3 years, 9 months ago (2017-03-21 14:34:38 UTC) #6
Evan Stade
lgtm
3 years, 9 months ago (2017-03-21 15:01:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755483005/20001
3 years, 9 months ago (2017-03-21 15:15:22 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 16:13:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/30d9c1420d887d155f3c4fcbf701...

Powered by Google App Engine
This is Rietveld 408576698