Fix android key event timestamps

Fix android key event timestamps

Pass a Java long to C++ as a jlong type, not a C++ long which can have a
different size to avoid broken / negative event timestamp values.
ImeAdapter's Java side uses "long" in SendKeyEvent, so the C++ side must
use a jlong or int64_t, and not a C++ long. Otherwise things don't work
well when system uptime is over 2^31ms (~25 days).

Additionally, do not do an extra divide-by-1000 when the used helper
function will do the milliseconds to seconds conversion already, so the
timestamps are correctly measured in milliseconds.

The resulting keyboard event timestamps end up nicely sane and positive,
and no longer clamped to 0 in PerformanceBase.cpp. 

BUG=701726
R=aelias@chromium.org

Review-Url: https://codereview.chromium.org/2755453004
Cr-Commit-Position: refs/heads/master@{#457369}
Committed: https://chromium.googlesource.com/chromium/src/+/6bda2b55ca3d254ca021560906d0703e8b0df21e

[tsniatowski, 2017-03-15 12:06:06]

PTAL

[tsniatowski, 2017-03-15 14:49:43]

Description was changed from

==========
Fix android key event timestamps

Pass a Java long to C++ as a jlong type, not a C++ long which can have a
different size to avoid broken / negative event timestamp values.
ImeAdapter's Java side uses "long" in SendKeyEvent, so the C++ side must
use a jlong or int64_t, and not a C++ long.

Additionally, do not do an extra divide-by-1000 when the used helper
function will do the milliseconds to seconds conversion already, so the
timestamps are correctly measured in milliseconds.

The resulting keyboard event timestamps end up nicely sane and positive,
and no longer clamped to 0 in PerformanceBase.cpp.

BUG=701726
R=aelias@chromium.org
==========

to

==========
Fix android key event timestamps

Pass a Java long to C++ as a jlong type, not a C++ long which can have a
different size to avoid broken / negative event timestamp values.
ImeAdapter's Java side uses "long" in SendKeyEvent, so the C++ side must
use a jlong or int64_t, and not a C++ long.

Additionally, do not do an extra divide-by-1000 when the used helper
function will do the milliseconds to seconds conversion already, so the
timestamps are correctly measured in milliseconds.

The resulting keyboard event timestamps end up nicely sane and positive,
and no longer clamped to 0 in PerformanceBase.cpp, even if system uptime
 is over 2^31ms (~25 days).

BUG=701726
R=aelias@chromium.org
==========

[aelias_OOO_until_Jul13, 2017-03-15 18:43:25]

lgtm

https://codereview.chromium.org/2755453004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/ime_adapter_android.h (right):

https://codereview.chromium.org/2755453004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/ime_adapter_android.h:46: jlong event_time,
nit: add "_ms"

[tsniatowski, 2017-03-16 07:41:00]

Description was changed from

==========
Fix android key event timestamps

Pass a Java long to C++ as a jlong type, not a C++ long which can have a
different size to avoid broken / negative event timestamp values.
ImeAdapter's Java side uses "long" in SendKeyEvent, so the C++ side must
use a jlong or int64_t, and not a C++ long.

Additionally, do not do an extra divide-by-1000 when the used helper
function will do the milliseconds to seconds conversion already, so the
timestamps are correctly measured in milliseconds.

The resulting keyboard event timestamps end up nicely sane and positive,
and no longer clamped to 0 in PerformanceBase.cpp, even if system uptime
 is over 2^31ms (~25 days).

BUG=701726
R=aelias@chromium.org
==========

to

==========
Fix android key event timestamps

Pass a Java long to C++ as a jlong type, not a C++ long which can have a
different size to avoid broken / negative event timestamp values.
ImeAdapter's Java side uses "long" in SendKeyEvent, so the C++ side must
use a jlong or int64_t, and not a C++ long. Otherwise things don't work
well when system uptime is over 2^31ms (~25 days).

Additionally, do not do an extra divide-by-1000 when the used helper
function will do the milliseconds to seconds conversion already, so the
timestamps are correctly measured in milliseconds.

The resulting keyboard event timestamps end up nicely sane and positive,
and no longer clamped to 0 in PerformanceBase.cpp. 

BUG=701726
R=aelias@chromium.org
==========

[tsniatowski, 2017-03-16 07:41:14]

https://codereview.chromium.org/2755453004/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/ime_adapter_android.h (right):

https://codereview.chromium.org/2755453004/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/ime_adapter_android.h:46: jlong event_time,
On 2017/03/15 18:43:25, aelias wrote:
> nit: add "_ms"

good point, changed to time_ms to match .cc

[tsniatowski, 2017-03-16 07:41:29]

The CQ bit was checked by tsniatowski@opera.com

[tsniatowski, 2017-03-16 07:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2755453004/#ps20001
(title: "event_time -> time_ms")

[commit-bot: I haz the power, 2017-03-16 07:41:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 08:17:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489650089886100,
"parent_rev": "da5f02c7b36a38453775a3b611f7c2f35934ce67", "commit_rev":
"6bda2b55ca3d254ca021560906d0703e8b0df21e"}

[commit-bot: I haz the power, 2017-03-16 08:18:38]

Description was changed from

==========
Fix android key event timestamps

Pass a Java long to C++ as a jlong type, not a C++ long which can have a
different size to avoid broken / negative event timestamp values.
ImeAdapter's Java side uses "long" in SendKeyEvent, so the C++ side must
use a jlong or int64_t, and not a C++ long. Otherwise things don't work
well when system uptime is over 2^31ms (~25 days).

Additionally, do not do an extra divide-by-1000 when the used helper
function will do the milliseconds to seconds conversion already, so the
timestamps are correctly measured in milliseconds.

The resulting keyboard event timestamps end up nicely sane and positive,
and no longer clamped to 0 in PerformanceBase.cpp. 

BUG=701726
R=aelias@chromium.org
==========

to

==========
Fix android key event timestamps

Pass a Java long to C++ as a jlong type, not a C++ long which can have a
different size to avoid broken / negative event timestamp values.
ImeAdapter's Java side uses "long" in SendKeyEvent, so the C++ side must
use a jlong or int64_t, and not a C++ long. Otherwise things don't work
well when system uptime is over 2^31ms (~25 days).

Additionally, do not do an extra divide-by-1000 when the used helper
function will do the milliseconds to seconds conversion already, so the
timestamps are correctly measured in milliseconds.

The resulting keyboard event timestamps end up nicely sane and positive,
and no longer clamped to 0 in PerformanceBase.cpp. 

BUG=701726
R=aelias@chromium.org

Review-Url: https://codereview.chromium.org/2755453004
Cr-Commit-Position: refs/heads/master@{#457369}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bda2b55ca3d254ca021560906d0...
==========

[commit-bot: I haz the power, 2017-03-16 08:18:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6bda2b55ca3d254ca021560906d0...