Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2755403002: Fix unique_ptr usage in handling OAuth2TokenService::StartRequest result (Closed)

Created:
3 years, 9 months ago by bsazonov
Modified:
3 years, 9 months ago
Reviewers:
msarda
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unique_ptr usage in handling OAuth2TokenService::StartRequest result Calling release() on a temporary unique_ptr to reset another unique_ptr with resulting raw pointer is verbose and obscure. It also loses custom deleter (see C++11 standard, clause 20.7.1.2.3.1). BUG=none Review-Url: https://codereview.chromium.org/2755403002 Cr-Commit-Position: refs/heads/master@{#458047} Committed: https://chromium.googlesource.com/chromium/src/+/e32318796eaf782ee8afe8ec047b1288f756f644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/signin/core/browser/child_account_info_fetcher_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bsazonov
Mihai, please take a look.
3 years, 9 months ago (2017-03-20 12:08:20 UTC) #6
msarda
lgtm
3 years, 9 months ago (2017-03-20 12:33:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755403002/1
3 years, 9 months ago (2017-03-20 13:01:52 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 13:06:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e32318796eaf782ee8afe8ec047b...

Powered by Google App Engine
This is Rietveld 408576698