third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp - Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters. (Closed)

Patch Set: fuzzer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModules.h ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp b/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

index a08f28e66737c245cab0a3d529caf56109b2b829..7af58c952a2b2d0a472864ccb7dd246957892f64 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

@@ -45,8 +45,9 @@ v8::Local<v8::Value> roundTrip(v8::Local<v8::Value> value,

RefPtr<ScriptState> scriptState = scope.getScriptState();

ExceptionState& exceptionState = scope.getExceptionState();

RefPtr<SerializedScriptValue> serializedScriptValue =

- V8ScriptValueSerializerForModules(scriptState)

- .serialize(value, nullptr, exceptionState);

+ V8ScriptValueSerializerForModules(

+ scriptState, V8ScriptValueSerializerForModules::Options())

+ .serialize(value, exceptionState);

DCHECK_EQ(!serializedScriptValue, exceptionState.hadException());

EXPECT_TRUE(serializedScriptValue);

if (!serializedScriptValue)

@@ -891,7 +892,7 @@ TEST(V8ScriptValueSerializerForModulesTest, RoundTripDOMFileSystemNotClonable) {

ASSERT_FALSE(fs->clonable());

v8::Local<v8::Value> wrapper = ToV8(fs, scope.getScriptState());

EXPECT_FALSE(V8ScriptValueSerializer(scope.getScriptState())

- .serialize(wrapper, nullptr, exceptionState));

+ .serialize(wrapper, exceptionState));

EXPECT_TRUE(hadDOMException("DataCloneError", scope.getScriptState(),

exceptionState));

}