Chromium Code Reviews
Help | Chromium Project | Sign in
(41)

Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by jbroman
Modified:
1 month ago
Reviewers:
haraken, Mircea Trofin
CC:
awdf+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, cmumford, jbroman+watch_chromium.org, jsbell+idb_chromium.org, kinuko+watch, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Encapsulate optional SerializedScriptValue serialize/deserialize parameters. By putting these options in a struct, it becomes easier to modify them without having to plumb the fields through several layers of abstraction. Review-Url: https://codereview.chromium.org/2755383004 Cr-Commit-Position: refs/heads/master@{#458410} Committed: https://chromium.googlesource.com/chromium/src/+/b4d8eb9df2ee1560fd4799da1e6524692e2c8669

Patch Set 1 #

Patch Set 2 : missed some #

Patch Set 3 : fuzzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -156 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 4 chunks +19 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 3 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 1 chunk +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.h View 1 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h View 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp View 3 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp View 1 12 chunks +54 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 1 chunk +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueDeserializerForModules.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModules.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSerializedScriptValue.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 19 (14 generated)
jbroman
[cc mtrofin] There are a few efforts which are likely to add more parameters to ...
1 month ago (2017-03-21 13:54:35 UTC) #12
haraken
LGTM
1 month ago (2017-03-21 14:26:58 UTC) #13
Mircea Trofin
On 2017/03/21 14:26:58, haraken wrote: > LGTM nice, lgtm!
1 month ago (2017-03-21 14:41:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755383004/40001
1 month ago (2017-03-21 14:47:56 UTC) #16
commit-bot: I haz the power
1 month ago (2017-03-21 14:53:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b4d8eb9df2ee1560fd4799da1e65...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46