Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2755373002: [arm64] The ubfx instruction can be used with a mask-width=64 (Closed)

Created:
3 years, 9 months ago by ahaas
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer, v8-arm-ports
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] The ubfx instruction can be used with a mask-width=64 The code-generator used i.InputInt6 to get the mask-width from the instruction. However, thereby 64 got wrapped to 0, which is an invalid mask width. I changed the i.InputInt6 to an i.InputInt32, which should be okay because the mask-width comes from base::bits::CountPopulation64. BUG=v8:6122 R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2755373002 Cr-Commit-Position: refs/heads/master@{#43927} Committed: https://chromium.googlesource.com/v8/v8/+/086ec2bd8d0ff97e0ea8f423d40fd13a5238038f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
ahaas
3 years, 9 months ago (2017-03-20 08:49:22 UTC) #1
Benedikt Meurer
LGTM, thanks!
3 years, 9 months ago (2017-03-20 09:12:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755373002/1
3 years, 9 months ago (2017-03-20 09:41:00 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 09:42:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/086ec2bd8d0ff97e0ea8f423d40fd13a523...

Powered by Google App Engine
This is Rietveld 408576698