Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2755293002: Capture from DOM elements: WPT idl tests (Closed)

Created:
3 years, 9 months ago by mcasas
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Capture from DOM elements: WPT idl tests I just found the power-of-idlharness-tests; this CL uses them for mediacapture-fromelement (now that WebKit has landed capture from canvas, it's even more widespread). (Inspired by https://crrev.com/2752383002/ WebUSB idlharness tests) BUG=702862 Review-Url: https://codereview.chromium.org/2755293002 Cr-Commit-Position: refs/heads/master@{#458172} Committed: https://chromium.googlesource.com/chromium/src/+/25d0f43b0bfbf2aaac0b333c739a4827a2d22240

Patch Set 1 #

Total comments: 4

Patch Set 2 : reillyg@ comments: corrected object creation #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html View 1 1 chunk +55 lines, -0 lines 2 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness-expected.txt View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
mcasas
emircan@ PTAL/RS plz
3 years, 9 months ago (2017-03-18 02:35:05 UTC) #3
mcasas
ping emircan@
3 years, 9 months ago (2017-03-19 20:38:06 UTC) #7
mcasas
reillyg@ RS plz
3 years, 9 months ago (2017-03-20 16:33:52 UTC) #9
emircan
lgtm
3 years, 9 months ago (2017-03-20 16:53:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755293002/1
3 years, 9 months ago (2017-03-20 16:56:27 UTC) #12
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html File third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html (right): https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html#newcode47 third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html:47: Media: [video.captureStream()], These should be "HTMLCanvasElement" and "HTMLMediaElement". That ...
3 years, 9 months ago (2017-03-20 16:56:40 UTC) #13
mcasas
https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html File third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html (right): https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html#newcode47 third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html:47: Media: [video.captureStream()], On 2017/03/20 16:56:40, Reilly Grant wrote: > ...
3 years, 9 months ago (2017-03-20 17:00:24 UTC) #14
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html File third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html (right): https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html#newcode47 third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html:47: Media: [video.captureStream()], On 2017/03/20 17:00:24, mcasas wrote: > On ...
3 years, 9 months ago (2017-03-20 17:05:39 UTC) #15
mcasas
reillyg@ PTAL https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html File third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html (right): https://codereview.chromium.org/2755293002/diff/1/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html#newcode47 third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html:47: Media: [video.captureStream()], On 2017/03/20 17:05:39, Reilly Grant ...
3 years, 9 months ago (2017-03-20 17:54:50 UTC) #17
Reilly Grant (use Gerrit)
lgtm https://codereview.chromium.org/2755293002/diff/20001/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html File third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html (right): https://codereview.chromium.org/2755293002/diff/20001/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html#newcode49 third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html:49: CanvasCaptureMediaStreamTrack: [canvas.captureStream().getTracks()[0]], If you want to test the ...
3 years, 9 months ago (2017-03-20 18:03:31 UTC) #18
mcasas
https://codereview.chromium.org/2755293002/diff/20001/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html File third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html (right): https://codereview.chromium.org/2755293002/diff/20001/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html#newcode49 third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/idlharness.html:49: CanvasCaptureMediaStreamTrack: [canvas.captureStream().getTracks()[0]], On 2017/03/20 18:03:31, Reilly Grant wrote: > ...
3 years, 9 months ago (2017-03-20 18:17:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755293002/20001
3 years, 9 months ago (2017-03-20 18:20:35 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 20:40:15 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25d0f43b0bfbf2aaac0b333c739a...

Powered by Google App Engine
This is Rietveld 408576698