Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2755263002: Revert of Revert "Revert of Move UrlManagerTest to junit (patchset #4 id:60001... (Closed)

Created:
3 years, 9 months ago by jbudorick
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium… (patchset #1 id:1 of https://codereview.chromium.org/2750003006/ ) Reason for revert: Failing at an elevated rate on linux_android_rel_ng. Original issue's description: > Revert "Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium.org/2723783003/ )" > > This reverts commit fa45e7d972ca1e35ffbe033a96203e5fa99bdf2d. > > Apparently the junit tests don't support @DisabledTest, so we use @Ignore > instead. Also, it restores our timeout on waiting for an upgrade to 5 > seconds, which apparently really did need to be that high. > > BUG=696804 > > Review-Url: https://codereview.chromium.org/2750003006 > Cr-Commit-Position: refs/heads/master@{#457875} > Committed: https://chromium.googlesource.com/chromium/src/+/ae09ef656ac3228c91a6fef38f3d386ee21f6faa TBR=dtrainor@chromium.org,cco3@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=696804 Review-Url: https://codereview.chromium.org/2755263002 Cr-Commit-Position: refs/heads/master@{#457900} Committed: https://chromium.googlesource.com/chromium/src/+/bb80229542ef5f3a648a857c36c125ec9d235a68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -463 lines) Patch
M chrome/android/java_sources.gni View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java View 1 chunk +84 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 chunk +351 lines, -0 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/MockPwsClient.java View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 chunk +0 lines, -377 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
Created Revert of Revert "Revert of Move UrlManagerTest to junit (patchset #4 id:60001 of https://codereview.chromium…
3 years, 9 months ago (2017-03-17 23:12:34 UTC) #2
cco3
lgtm
3 years, 9 months ago (2017-03-17 23:13:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755263002/1
3 years, 9 months ago (2017-03-17 23:13:37 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 23:15:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb80229542ef5f3a648a857c36c1...

Powered by Google App Engine
This is Rietveld 408576698