MD WebUI: fix action menu initial focus to be more like context menus

MD WebUI: fix action menu initial focus to be more like context menus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=656924
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2755213002
Cr-Commit-Position: refs/heads/master@{#457977}
Committed: https://chromium.googlesource.com/chromium/src/+/25958da94dac85cfe9cf3ec07d428fa0d75aab8e

[Dan Beam, 2017-03-17 21:56:11]

Description was changed from

==========
MD WebUI: fix action menu initial focus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=none
==========

to

==========
MD WebUI: fix action menu initial focus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-17 23:32:45]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2017-03-17 23:33:11]

btw, this is on the UI polish spreadsheet, there's just not bugs filed for all
of those yet

[commit-bot: I haz the power, 2017-03-17 23:33:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-03-18 00:26:01]

Description was changed from

==========
MD WebUI: fix action menu initial focus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: fix action menu initial focus to be more like context menus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-18 01:03:05]

Is this CL addressing
https://bugs.chromium.org/p/chromium/issues/detail?id=656924? If so let's add it
to the description.

LGTM

https://codereview.chromium.org/2755213002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/cr_elements/cr_action_menu_test.js (right):

https://codereview.chromium.org/2755213002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/cr_elements/cr_action_menu_test.js:70:
assertNotEquals(items[0], menu.root.activeElement);
Optional nit: What is the value of menu.root.activeElement at this point? Is it
null? Perhaps you can replace all 3 assertions with a single assertion.

assertEquals(null, menu.root.activeElement);

[commit-bot: I haz the power, 2017-03-18 01:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:22:56]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Dan Beam, 2017-03-18 17:54:18]

Description was changed from

==========
MD WebUI: fix action menu initial focus to be more like context menus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: fix action menu initial focus to be more like context menus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=656924
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-18 17:55:06]

https://codereview.chromium.org/2755213002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/cr_elements/cr_action_menu_test.js (right):

https://codereview.chromium.org/2755213002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/cr_elements/cr_action_menu_test.js:70:
assertNotEquals(items[0], menu.root.activeElement);
On 2017/03/18 01:03:05, dpapad wrote:
> Optional nit: What is the value of menu.root.activeElement at this point? Is
it
> null? Perhaps you can replace all 3 assertions with a single assertion.
> 
> assertEquals(null, menu.root.activeElement);

it's not null, it's a wrapper in the shadow DOM and I don't think the test
should know about it (or at least it doesn't seem useful)

[Dan Beam, 2017-03-18 17:55:11]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-18 17:55:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 19:48:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489859711371000,
"parent_rev": "9eadd39fcd5cd2e882a88a791e05c1ed83ec6fe6", "commit_rev":
"25958da94dac85cfe9cf3ec07d428fa0d75aab8e"}

[commit-bot: I haz the power, 2017-03-18 19:49:40]

Description was changed from

==========
MD WebUI: fix action menu initial focus to be more like context menus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=656924
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: fix action menu initial focus to be more like context menus

This is easily possible now because <dialog>#showModal() looks into
shadow DOM.

R=dpapad@chromium.org
BUG=656924
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2755213002
Cr-Commit-Position: refs/heads/master@{#457977}
Committed:
https://chromium.googlesource.com/chromium/src/+/25958da94dac85cfe9cf3ec07d42...
==========

[commit-bot: I haz the power, 2017-03-18 19:49:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25958da94dac85cfe9cf3ec07d42...