Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(362)

Issue 2755163002: [Mac] Fix keyword hint spacing in RTL (Closed)

Created:
1 year, 1 month ago by lgrey
Modified:
1 year, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix keyword hint spacing in RTL BUG=668380 Review-Url: https://codereview.chromium.org/2755163002 Cr-Commit-Position: refs/heads/master@{#458064} Committed: https://chromium.googlesource.com/chromium/src/+/ab1f101d05be92332f8c4a8532f6807e580c0568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lgrey
PTAL :)
1 year, 1 month ago (2017-03-17 18:47:07 UTC) #2
Robert Sesek
lgtm
1 year, 1 month ago (2017-03-17 19:36:09 UTC) #3
lgrey
On 2017/03/17 19:36:09, Robert Sesek wrote: > lgtm Thanks!
1 year, 1 month ago (2017-03-17 19:40:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755163002/1
1 year, 1 month ago (2017-03-17 19:40:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/409541)
1 year, 1 month ago (2017-03-17 22:20:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755163002/1
1 year, 1 month ago (2017-03-20 14:52:08 UTC) #10
commit-bot: I haz the power
1 year, 1 month ago (2017-03-20 15:14:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab1f101d05be92332f8c4a8532f6...

Powered by Google App Engine
This is Rietveld 408576698