Create ReadingListSuggestionsProvider

components/ntp_snippets/BUILD.gn

Index: components/ntp_snippets/BUILD.gn
diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn
index a99765e268babe212054f691022a16f681efeb5c..d589043d5e5bce3604dad67c06af9612bea8ca95 100644
--- a/components/ntp_snippets/BUILD.gn
+++ b/components/ntp_snippets/BUILD.gn
@@ -138,6 +138,7 @@ source_set("unit_tests") {
     "category_unittest.cc",
     "content_suggestions_metrics_unittest.cc",
     "content_suggestions_service_unittest.cc",
+    "ios/reading_list_suggestions_provider_unittest.cc",
     "offline_pages/recent_tab_suggestions_provider_unittest.cc",
     "physical_web_pages/physical_web_page_suggestions_provider_unittest.cc",
     "remote/json_request_unittest.cc",
@@ -164,6 +165,7 @@ source_set("unit_tests") {
     "//components/bookmarks/test",
     "//components/image_fetcher/core",
     "//components/leveldb_proto:test_support",
+    "//components/ntp_snippets/ios",

[Marc Treib, 2017/03/23 17:12:21]

This seems wrong. The general build file shouldn't reference the ios/ subfolder.
How about making a "reading_list" folder after all, and having an "ios"
subfolder in there, which then contains all the actual ios-only stuff?

[gambard, 2017/03/23 17:49:39]

Ok, as there is no iOS-only stuff (only things which are not needed on other
platform), I am moving it to reading_list.

[Marc Treib, 2017/03/23 19:01:49]

Ah, so we *could* actually build it on all platforms without issues? Then TBH,
I'd just do that. The impact on build time should be negligible - through the
tests, all the code will get compiled anyway. And the build file setup will be
much simpler that way.
Am I missing something?
Anyway, I'll leave the final decision to you.

[jkrcal, 2017/03/24 08:45:19]

I also value simplicity and tend to agree with Marc.
However, I am also fine with the proposed separate BUILD setup.

[gambard, 2017/03/24 09:08:50]

It is more that we have one target per folder in ios/ so I am used to it :)
Moved to ntp_snippets/BUILD

     "//components/ntp_snippets/remote/proto",
     "//components/offline_pages/core",
     "//components/offline_pages/core:test_support",
@@ -171,6 +173,7 @@ source_set("unit_tests") {
     "//components/offline_pages/core/downloads:offline_pages_ui_adapter",
     "//components/offline_pages/core/recent_tabs",
     "//components/physical_web/data_source:test_support",
+    "//components/reading_list/core",
     "//components/sessions",
     "//components/sessions:test_support",
     "//components/signin/core/browser:test_support",