Create ReadingListSuggestionsProvider

components/ntp_snippets/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
   import("//build/config/android/rules.gni")
 }
@@ skipping 120 matching lines @@
 source_set("unit_tests") {
   testonly = true
   sources = [
     "bookmarks/bookmark_last_visit_utils_unittest.cc",
     "bookmarks/bookmark_suggestions_provider_unittest.cc",
     "category_rankers/click_based_category_ranker_unittest.cc",
     "category_rankers/constant_category_ranker_unittest.cc",
     "category_unittest.cc",
     "content_suggestions_metrics_unittest.cc",
     "content_suggestions_service_unittest.cc",
+    "ios/reading_list_suggestions_provider_unittest.cc",
     "offline_pages/recent_tab_suggestions_provider_unittest.cc",
     "physical_web_pages/physical_web_page_suggestions_provider_unittest.cc",
     "remote/json_request_unittest.cc",
     "remote/remote_suggestion_unittest.cc",
     "remote/remote_suggestions_database_unittest.cc",
     "remote/remote_suggestions_fetcher_unittest.cc",
     "remote/remote_suggestions_provider_impl_unittest.cc",
     "remote/remote_suggestions_status_service_unittest.cc",
     "remote/request_throttler_unittest.cc",
     "remote/scheduling_remote_suggestions_provider_unittest.cc",
     "remote/test_utils.cc",
     "remote/test_utils.h",
     "sessions/foreign_sessions_suggestions_provider_unittest.cc",
     "sessions/tab_delegate_sync_adapter_unittest.cc",
     "user_classifier_unittest.cc",
   ]
 
   deps = [
     ":ntp_snippets",
     ":test_support",
     "//base",
     "//base/test:test_support",
     "//components/bookmarks/browser",
     "//components/bookmarks/test",
     "//components/image_fetcher/core",
     "//components/leveldb_proto:test_support",
+    "//components/ntp_snippets/ios",

[Marc Treib, 2017/03/23 17:12:21]

This seems wrong. The general build file shouldn't reference the ios/ subfolder.
How about making a "reading_list" folder after all, and having an "ios"
subfolder in there, which then contains all the actual ios-only stuff?

[gambard, 2017/03/23 17:49:39]

Ok, as there is no iOS-only stuff (only things which are not needed on other
platform), I am moving it to reading_list.

[Marc Treib, 2017/03/23 19:01:49]

Ah, so we *could* actually build it on all platforms without issues? Then TBH,
I'd just do that. The impact on build time should be negligible - through the
tests, all the code will get compiled anyway. And the build file setup will be
much simpler that way.
Am I missing something?
Anyway, I'll leave the final decision to you.

[jkrcal, 2017/03/24 08:45:19]

I also value simplicity and tend to agree with Marc.
However, I am also fine with the proposed separate BUILD setup.

[gambard, 2017/03/24 09:08:50]

It is more that we have one target per folder in ios/ so I am used to it :)
Moved to ntp_snippets/BUILD

     "//components/ntp_snippets/remote/proto",
     "//components/offline_pages/core",
     "//components/offline_pages/core:test_support",
     "//components/offline_pages/core/background:test_support",
     "//components/offline_pages/core/downloads:offline_pages_ui_adapter",
     "//components/offline_pages/core/recent_tabs",
     "//components/physical_web/data_source:test_support",
+    "//components/reading_list/core",
     "//components/sessions",
     "//components/sessions:test_support",
     "//components/signin/core/browser:test_support",
     "//components/signin/core/common",
     "//components/strings",
     "//components/sync:test_support_driver",
     "//components/sync_sessions",
     "//components/variations:test_support",
     "//net:test_support",
     "//testing/gtest",
@@ skipping 21 matching lines @@
 
   deps = [
     ":ntp_snippets",
     "//base",
     "//components/offline_pages/core",
     "//components/offline_pages/core:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
 }