Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10475)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/predictors/subresource_fcp_order.html

Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp. (Closed)
Patch Set: Respond to feedback. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc ('K') | « chrome/browser/ui/webui/predictors/predictors_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/predictors/subresource_fcp_order.html
diff --git a/chrome/test/data/predictors/subresource_fcp_order.html b/chrome/test/data/predictors/subresource_fcp_order.html
new file mode 100644
index 0000000000000000000000000000000000000000..21e15776b21a56daa8499df107421414eda355d1
--- /dev/null
+++ b/chrome/test/data/predictors/subresource_fcp_order.html
@@ -0,0 +1,18 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <title>Subresources collection</title>
+ <link rel="stylesheet" href="/handled-by-test/style.css">
+ <script src="/handled-by-test/script.js"></script>
+ </head>
+ <body>
+ <p>Hello world!</p>
+ <script id="script">
alexilin 2017/04/25 18:42:21 I don't completely understand why your test is wor
alexilin 2017/04/26 09:25:01 Discussed offline: This version of test had a comp
+ // Using document.write would allow the preload scanner to pick up this
+ // resource and throw off results.
+ document.getElementById('script').insertAdjacentHTML('afterend',
+ `<img src="/handled-by-test/image.png">`);
+ </script>
+ <script src="/handled-by-test/long-script.js"></script>
+ </body>
+</html>
« chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc ('K') | « chrome/browser/ui/webui/predictors/predictors_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698