chrome/test/data/predictors/subresource_fcp_order.html - Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/predictors/subresource_fcp_order.html

Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp. (Closed)

Patch Set: Respond to feedback. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Subresources collection</title>

	5 <link rel="stylesheet" href="/handled-by-test/style.css">

	6 <script src="/handled-by-test/script.js"></script>

	7 </head>

	8 <body>

	9 <p>Hello world!</p>

	10 <script id="script">
	alexilin 2017/04/25 18:42:21 I don't completely understand why your test is wor I don't completely understand why your test is working. Scripts are executed from top to bottom. Thus this inline script should be executed before the parser stops at long-script. Hence the image tag should be inserted and processed before the parser reaches long-script. What am I missing? I'd be less surprising for me to see inline script after long-script. alexilin 2017/04/26 09:25:01 Discussed offline: This version of test had a comp Show quoted text On 2017/04/25 18:42:21, alexilin wrote: > I don't completely understand why your test is working. Scripts are executed > from top to bottom. Thus this inline script should be executed before the parser > stops at long-script. Hence the image tag should be inserted and processed > before the parser reaches long-script. > What am I missing? > I'd be less surprising for me to see inline script after long-script. Discussed offline: This version of test had a complicated behavior. There is a race between preload scanner that issues a request for long-script.js and html-parser that executes the inline script and issues a request for image.png. If the request for long-script.js arrives to the embedded HTTP server earlier than the request for image.png then the test works as expected. Because the HTTP server synchronously waits for a delay before it sends a response for long-script.js and a response for image.png always sent after. Anyway, it's possible that HTTP server gets a request for image.png before, then the test could fail.
	11 // Using document.write would allow the preload scanner to pick up this

	12 // resource and throw off results.

	13 document.getElementById('script').insertAdjacentHTML('afterend',

	14 `<img src="/handled-by-test/image.png">`);

	15 </script>

	16 <script src="/handled-by-test/long-script.js"></script>

	17 </body>

	18 </html>

OLD	NEW

« chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc ('K') | « chrome/browser/ui/webui/predictors/predictors_handler.cc ('k') | no next file » | no next file with comments »