Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2755073003: [Merge M58] arc: Reactivate OptIn flow on clicking Play Store. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] arc: Reactivate OptIn flow on clicking Play Store. This fixes broken flow when ARC OptIn can be re-activated for managed user in case user clicks Play Store icon in App Launcher or on shelf. TEST=Manually + unit_test added BUG=700601 TBR=xiyuan@chromium.org,yusukes@chromium.org,oshima@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2739323004 Cr-Commit-Position: refs/heads/master@{#457107} (cherry picked from commit 919bb1a623fd23ecbcd3664ff45d63cec36da977) Review-Url: https://codereview.chromium.org/2755073003 Cr-Commit-Position: refs/branch-heads/3029@{#275} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/049b2f224e9ab42fbf962a70e3a71d4fa79d4e01

Patch Set 1 #

Patch Set 2 : resolve merge conflict #

Patch Set 3 : update unit_tests expectation for M58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -23 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager_unittest.cc View 1 2 3 chunks +55 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_util.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc View 2 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755073003/40001
3 years, 9 months ago (2017-03-17 19:52:58 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 20:05:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/049b2f224e9ab42fbf962a70e3a7...

Powered by Google App Engine
This is Rietveld 408576698