Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2755043002: Remove ComputedStyle::initializeBitDefaults(). (Closed)

Created:
3 years, 9 months ago by shend
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ComputedStyle::initializeBitDefaults(). Previously, the data members in ComputedStyle were initialized using a method called initializeBitDefaults(). This was to avoid duplicating code for the two constructors in ComputedStyle. Now that there is only one constructor in ComputedStyle (that initializes the initial style), we can remove this method. This patch replaces the initializeBitDefaults() method with proper initializer lists in ComputedStyle, InheritedData and NonInheritedData. It also removes the initial style tag from the ComputedStyle constructor since we no longer have to differentiate between two constructors. BUG=628043 Review-Url: https://codereview.chromium.org/2755043002 Cr-Commit-Position: refs/heads/master@{#458006} Committed: https://chromium.googlesource.com/chromium/src/+/8f1b6debc47bc4c5e528fe56a7941c36b04c7f1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 3 chunks +16 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
shend
Hi Bugs, PTAL :)
3 years, 9 months ago (2017-03-17 00:32:18 UTC) #2
Bugs Nash
On 2017/03/17 at 00:32:18, shend wrote: > Hi Bugs, PTAL :) lgtm, this is great! ...
3 years, 9 months ago (2017-03-17 05:07:36 UTC) #3
shend
Hi Eddy, PTAL
3 years, 9 months ago (2017-03-17 05:16:06 UTC) #5
shend
On 2017/03/17 at 05:07:36, bugsnash wrote: > On 2017/03/17 at 00:32:18, shend wrote: > > ...
3 years, 9 months ago (2017-03-17 05:22:43 UTC) #6
meade_UTC10
lgtm
3 years, 9 months ago (2017-03-17 06:43:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755043002/1
3 years, 9 months ago (2017-03-19 21:18:20 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-19 23:48:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f1b6debc47bc4c5e528fe56a794...

Powered by Google App Engine
This is Rietveld 408576698