Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2755033003: DevTools: [regression] can't disable remote debugging data saver infobar. (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
paulirish
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [regression] can't disable remote debugging data saver infobar. BUG=702471 Review-Url: https://codereview.chromium.org/2755033003 Cr-Commit-Position: refs/heads/master@{#457717} Committed: https://chromium.googlesource.com/chromium/src/+/594213c12557fdd9035935f29835027a46a458e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/components/DataSaverInfobar.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
pfeldman
3 years, 9 months ago (2017-03-17 03:23:04 UTC) #2
paulirish
you could allow `dispose` to fall through and then with `infobar.setCloseCallback` iterate over the remaining ...
3 years, 9 months ago (2017-03-17 03:44:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755033003/1
3 years, 9 months ago (2017-03-17 03:59:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/385707)
3 years, 9 months ago (2017-03-17 06:48:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755033003/1
3 years, 9 months ago (2017-03-17 07:38:08 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 08:48:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/594213c12557fdd9035935f29835...

Powered by Google App Engine
This is Rietveld 408576698