Refactor WPTExpectationsUpdater.get_tests_to_rebaseline.

Refactor WPTExpectationsUpdater.get_tests_to_rebaseline.

The purpose of this CL is just to try to make this method a bit easier
to understand; this shouldn't change behavior.

Review-Url: https://codereview.chromium.org/2755033002
Cr-Commit-Position: refs/heads/master@{#457832}
Committed: https://chromium.googlesource.com/chromium/src/+/eec951210211f3cb77495a9ece3c236b08b53036

[qyearsley, 2017-03-16 23:39:29]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-03-16 23:39:29]

Hi Jeff,

Some background about this:

This is part of the import process -- after try jobs are finished,
wpt-update-expectations is run; this script looks at the test results, and it
(1) rebaselines if possible, or otherwise (2) adds test expectation lines.

Let me know if anything is particularly confusing or if this might change the
behavior in some subtle way :-)

[jeffcarp, 2017-03-17 00:08:57]

lgtm

[qyearsley, 2017-03-17 15:33:26]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 15:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-03-17 17:00:57]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-03-17 17:00:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2755033002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-17 17:01:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:51:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489770057616700,
"parent_rev": "8ffd86e6c9e28bcab01a3f59fb288a7f20df2090", "commit_rev":
"eec951210211f3cb77495a9ece3c236b08b53036"}

[commit-bot: I haz the power, 2017-03-17 18:52:10]

Description was changed from

==========
Refactor WPTExpectationsUpdater.get_tests_to_rebaseline.

The purpose of this CL is just to try to make this method a bit easier
to understand; this shouldn't change behavior.
==========

to

==========
Refactor WPTExpectationsUpdater.get_tests_to_rebaseline.

The purpose of this CL is just to try to make this method a bit easier
to understand; this shouldn't change behavior.

Review-Url: https://codereview.chromium.org/2755033002
Cr-Commit-Position: refs/heads/master@{#457832}
Committed:
https://chromium.googlesource.com/chromium/src/+/eec951210211f3cb77495a9ece3c...
==========

[commit-bot: I haz the power, 2017-03-17 18:52:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eec951210211f3cb77495a9ece3c...