Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2755013003: Remove unneeded `strong_mode_down_cast_composite` ignores. (Closed)

Created:
3 years, 9 months ago by pquitslund
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unneeded `strong_mode_down_cast_composite` ignores. As `strong_mode_down_cast_composite` is now a strong-mode hint these should no longer need to be explicitly ignored. Follow-up from: https://github.com/flutter/flutter/pull/8853 BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/09886f491fa7ce21b7956b3bd8882983956ceeac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
M pkg/analyzer/lib/src/summary/fasta/summary_builder.dart View 27 chunks +0 lines, -40 lines 0 comments Download
M pkg/analyzer/tool/summary/mini_ast.dart View 7 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pquitslund
3 years, 9 months ago (2017-03-17 17:22:02 UTC) #2
Paul Berry
lgtm
3 years, 9 months ago (2017-03-17 19:10:21 UTC) #3
pquitslund
3 years, 9 months ago (2017-03-17 19:33:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09886f491fa7ce21b7956b3bd8882983956ceeac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698