Remove unneeded `strong_mode_down_cast_composite` ignores.

pkg/analyzer/lib/src/summary/fasta/summary_builder.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Logic to build unlinked summaries.
 library summary.src.summary_builder;
 
 import 'package:front_end/src/fasta/parser/class_member_parser.dart';
 import 'package:front_end/src/fasta/parser/identifier_context.dart';
 import 'package:front_end/src/fasta/parser/parser.dart';
@@ skipping 238 matching lines @@
     _withinCascades--;
     throw new UnimplementedError(); // TODO(paulberry): fix the code below.
     // _endCascade();
   }
 
   void endConstructorReference(
       Token start, Token periodBeforeName, Token endToken) {
     debugEvent("ConstructorReference $start $periodBeforeName");
     Ref ctorName = popIfNotNull(periodBeforeName);
     assert(ctorName?.prefix == null);
-    // ignore: strong_mode_down_cast_composite
     List<TypeRef> typeArgs = pop();
     Ref type = pop();
     push(new ConstructorName(new TypeRef(type, typeArgs), ctorName?.name));
   }
 
   void endFormalParameter(
       Token covariantKeyword, Token thisKeyword, FormalParameterType kind) {
     debugEvent("FormalParameter");
     assert(ignore);
   }
@@ skipping 45 matching lines @@
   void endReturnStatement(hasValue, Token begin, Token end) {
     debugEvent("ReturnStatement");
     assert(ignore);
   }
 
   // type-arguments are expected to be type references passed to constructors
   // and generic methods, we need them to model instantiations.
   void endSend(Token beginToken, Token endToken) {
     debugEvent("EndSend");
     if (ignore) return;
-    // ignore: strong_mode_down_cast_composite
     List<Expression> args = pop();
     if (args != null) {
       /* var typeArgs = */ pop();
       var receiver = pop();
       // TODO(sigmund): consider making identical a binary operator.
       if (receiver is Ref && receiver.name == 'identical') {
         assert(receiver.prefix == null);
         assert(args.length == 2);
         push(new Identical(args[0], args[1]));
         return;
@@ skipping 71 matching lines @@
     push(new Conditional(cond, trueBranch, falseBranch));
   }
 
   void handleConstExpression(Token token) {
     debugEvent("ConstExpression");
     if (ignore) return;
     List args = pop();
     var constructorName = pop();
     var positional = args.where((a) => a is! NamedArg).toList();
     var named = args.where((a) => a is NamedArg).toList();
-    // ignore: strong_mode_down_cast_composite
     push(new ConstCreation(constructorName, positional, named));
   }
 
   void handleIdentifier(Token token, IdentifierContext context) {
     debugEvent("Identifier");
     if (ignore) return;
     push(new Ref(token.lexeme));
   }
 
   void handleIsOperator(Token operator, Token not, Token endToken) {
@@ skipping 17 matching lines @@
   void handleLiteralInt(Token token) {
     debugEvent("LiteralInt");
     if (ignore) return;
     push(new IntLiteral(int.parse(token.lexeme)));
   }
 
   void handleLiteralList(count, begin, constKeyword, end) {
     debugEvent("LiteralList");
     if (ignore) return;
     var values = popList(count) ?? const <Expression>[];
-    // ignore: strong_mode_down_cast_composite
     List<TypeRef> typeArguments = pop();
     var type = typeArguments?.single;
-    // ignore: strong_mode_down_cast_composite
     push(new ListLiteral(type, values, constKeyword != null));
   }
 
   void handleLiteralMap(count, begin, constKeyword, end) {
     debugEvent('LiteralMap');
     if (ignore) return;
     var values = popList(count) ?? const <KeyValuePair>[];
     var typeArgs = pop() ?? const <TypeRef>[];
-    // ignore: strong_mode_down_cast_composite
     push(new MapLiteral(typeArgs, values, constKeyword != null));
   }
 
   void handleLiteralNull(Token token) {
     debugEvent("LiteralNull");
     if (ignore) return;
     push(new NullLiteral());
   }
 
   void handleModifier(Token token) {
@@ skipping 70 matching lines @@
 
   void handleStringPart(token) {
     debugEvent("handleStringPart");
     if (ignore) return;
     push(new StringLiteral(token.lexeme));
   }
 
   void handleType(Token beginToken, Token endToken) {
     debugEvent("Type");
     if (ignore) return;
-    // ignore: strong_mode_down_cast_composite
     List<TypeRef> arguments = pop();
     Ref name = pop();
     push(new TypeRef(name, arguments));
   }
 
   void handleUnaryPrefixExpression(Token operator) {
     debugEvent("UnaryPrefix");
     if (ignore) return;
     push(new Unary(pop(), operator.kind));
   }
@@ skipping 287 matching lines @@
   }
 
   void endClassDeclaration(
       int interfacesCount,
       Token beginToken,
       Token classKeyword,
       Token extendsKeyword,
       Token implementsKeyword,
       Token endToken) {
     debugEvent("endClassDeclaration");
-    // ignore: strong_mode_down_cast_composite
     List<EntityRefBuilder> interfaces = popList(interfacesCount);
     EntityRef supertype = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedTypeParamBuilder> typeVariables = pop();
     String name = pop();
     int modifiers = pop();
     List metadata = pop();
     checkEmpty();
 
     ClassScope s = scope;
     s.className = name;
     s.currentClass
       ..name = name
       ..isAbstract = modifiers & _abstract_flag != 0
-      // ignore: strong_mode_down_cast_composite
       ..annotations = metadata
       ..typeParameters = typeVariables
       ..interfaces = interfaces;
     if (supertype != null) {
       s.currentClass.supertype = supertype;
     } else {
       s.currentClass.hasNoSupertype = isCoreLibrary && name == 'Object';
     }
     scope = scope.parent;
     topScope.unit.classes.add(s.currentClass);
@@ skipping 46 matching lines @@
     var className = pop();
     push(['ctor-ref:', className, typeArguments, ctorName]);
   }
 
   void endDottedName(count, firstIdentifier) {
     push(popList(count).join('.'));
   }
 
   void endEnum(Token enumKeyword, Token endBrace, int count) {
     debugEvent("Enum");
-    // ignore: strong_mode_down_cast_composite
     List<String> constants = popList(count);
     String name = pop();
     List metadata = pop();
     checkEmpty();
     EnumScope s = scope;
     scope = s.parent;
     s.currentEnum
       ..name = name
-      // ignore: strong_mode_down_cast_composite
       ..annotations = metadata;
     s.top.unit.enums.add(s.currentEnum);
 
     // public namespace:
     var e = new UnlinkedPublicNameBuilder(
         name: name, kind: ReferenceKind.classOrEnum, numTypeParameters: 0);
     for (var s in constants) {
       e.members.add(new UnlinkedPublicNameBuilder(
           name: s, kind: ReferenceKind.propertyAccessor, numTypeParameters: 0));
     }
     topScope.publicNamespace.names.add(e);
   }
 
   void endExport(Token exportKeyword, Token semicolon) {
     debugEvent("Export");
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedCombinator> combinators = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedConfiguration> conditionalUris = pop();
     String uri = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedExpr> metadata = pop();
     topScope.unit.exports
         .add(new UnlinkedExportNonPublicBuilder(annotations: metadata));
     topScope.publicNamespace.exports.add(new UnlinkedExportPublicBuilder(
         uri: uri, combinators: combinators, configurations: conditionalUris));
     checkEmpty();
   }
 
   void endFactoryMethod(
       Token beginToken, Token factoryKeyword, Token endToken) {
@@ skipping 34 matching lines @@
     // TODO(sigmund): clean up?
     var nameOrFormal = pop();
     if (nameOrFormal is String) {
       EntityRef type = pop();
       pop(); // Modifiers
       List metadata = pop();
       push(new UnlinkedParamBuilder(
           name: nameOrFormal,
           kind: _nextParamKind,
           inheritsCovariantSlot: slotIf(type == null),
-          // ignore: strong_mode_down_cast_composite
           annotations: metadata,
           isInitializingFormal: thisKeyword != null,
           type: type));
     } else {
       push(nameOrFormal);
     }
   }
 
   void endFormalParameters(int count, Token beginToken, Token endToken) {
     debugEvent("FormalParameters");
@@ skipping 20 matching lines @@
     List typeVariables = pop();
     String name = pop();
     EntityRef returnType = pop();
     List metadata = pop();
     // print('TODO: type alias $name');
     checkEmpty();
 
     scope = scope.parent;
     topScope.unit.typedefs.add(new UnlinkedTypedefBuilder(
         name: name,
-        // ignore: strong_mode_down_cast_composite
         typeParameters: typeVariables,
         returnType: returnType,
-        // ignore: strong_mode_down_cast_composite
         parameters: formals,
-        // ignore: strong_mode_down_cast_composite
         annotations: metadata));
 
     _addNameIfPublic(name, ReferenceKind.typedef, typeVariables.length);
   }
 
   void endFunctionTypedFormalParameter(
       Token covariantKeyword, Token thisKeyword, FormalParameterType kind) {
     debugEvent("FunctionTypedFormalParameter");
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedParamBuilder> formals = pop();
     if (formals != null) formals.forEach((p) => p.inheritsCovariantSlot = null);
 
     /* List typeVariables = */ pop();
     String name = pop();
     EntityRef returnType = pop();
     /* int modifiers = */ pop();
     List metadata = pop();
 
     push(new UnlinkedParamBuilder(
         name: name,
         kind: _nextParamKind,
         isFunctionTyped: true,
         parameters: formals,
-        // ignore: strong_mode_down_cast_composite
         annotations: metadata,
         type: returnType));
   }
 
   void endHide(_) {
-    // ignore: strong_mode_down_cast_composite
     push(new UnlinkedCombinatorBuilder(hides: pop()));
   }
 
   void endIdentifierList(int count) {
     debugEvent("endIdentifierList");
     push(popList(count) ?? NullValue.IdentifierList);
   }
 
   void endImport(Token importKeyword, Token deferredKeyword, Token asKeyword,
       Token semicolon) {
     debugEvent("endImport");
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedCombinator> combinators = pop();
     String prefix = popIfNotNull(asKeyword);
     int prefixIndex =
         prefix == null ? null : topScope.serializeReference(null, prefix);
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedConfiguration> conditionalUris = pop();
     String uri = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedExpr> metadata = pop(); // metadata
 
     topScope.unit.imports.add(new UnlinkedImportBuilder(
       uri: uri,
       prefixReference: prefixIndex,
       combinators: combinators,
       configurations: conditionalUris,
       isDeferred: deferredKeyword != null,
       annotations: metadata,
     ));
     if (uri == 'dart:core') isDartCoreImported = true;
     checkEmpty();
   }
 
   void endInitializer(Token assignmentOperator) {
     // TODO(paulberry): add support for this.
     debugEvent("Initializer $typeSeen $assignmentOperator");
   }
 
   void endInitializers(int count, Token beginToken, Token endToken) {
     debugEvent("Initializers");
     // TODO(sigmund): include const-constructor initializers
   }
 
   void endLibraryName(Token libraryKeyword, Token semicolon) {
     debugEvent("endLibraryName");
     String name = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedExpr> metadata = pop(); // metadata
 
     topScope.unit.libraryName = name;
     topScope.unit.libraryAnnotations = metadata;
     if (name == 'dart.core') isCoreLibrary = true;
   }
 
   void endLiteralString(int interpolationCount, Token endToken) {
     assert(interpolationCount == 0); // TODO(sigmund): handle interpolation
   }
@@ skipping 25 matching lines @@
   }
 
   void endMetadataStar(int count, bool forParameter) {
     debugEvent("MetadataStar");
     push(popList(count) ?? NullValue.Metadata);
   }
 
   void endMethod(Token getOrSet, Token beginToken, Token endToken) {
     debugEvent("Method");
     int asyncModifier = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedParam> formals = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedTypeParamBuilder> typeVariables = pop();
     String name = pop();
     EntityRef returnType = pop();
     int modifiers = pop();
     List metadata = pop();
 
     ClassScope s = scope;
     bool isStatic = modifiers & _static_flag != 0;
     bool isConst = modifiers & _const_flag != 0;
     bool isGetter = getOrSet == 'get';
@@ skipping 20 matching lines @@
         isExternal: modifiers & _external_flag != 0,
         isAbstract: modifiers & _abstract_flag != 0,
         isAsynchronous: asyncModifier & _async_flag != 0,
         isGenerator: asyncModifier & _star_flag != 0,
         isStatic: isStatic,
         isConst: isConst,
         constCycleSlot: slotIf(isConst),
         typeParameters: typeVariables,
         returnType: returnType,
         parameters: formals, // TODO: add inferred slot to args
-        // ignore: strong_mode_down_cast_composite
         annotations: metadata,
         inferredReturnTypeSlot:
             slotIf(returnType == null && !isStatic && !isConstructor)));
 
     if (isConstructor && name == '') return;
     if (_isPrivate(name)) return;
     if (isSetter || isOperator) return;
     if (!isStatic && !isConstructor) return;
     s.publicName.members.add(new UnlinkedPublicNameBuilder(
         name: name,
         kind: isGetter
             ? ReferenceKind.propertyAccessor
             : (isConstructor
                 ? ReferenceKind.constructor
                 : ReferenceKind.method),
         numTypeParameters: typeVariables.length));
   }
 
   void endMixinApplication(Token withKeyword) {
     debugEvent("MixinApplication");
     ClassScope s = scope;
-    // ignore: strong_mode_down_cast_composite
     s.currentClass.mixins = pop();
   }
 
   void endNamedMixinApplication(Token begin, Token classKeyword, Token equals,
       Token implementsKeyword, Token endToken) {
     debugEvent("endNamedMixinApplication");
-    // ignore: strong_mode_down_cast_composite
     List<EntityRef> interfaces = popIfNotNull(implementsKeyword);
     EntityRef supertype = pop();
     List typeVariables = pop();
     String name = pop();
     int modifiers = pop();
     List metadata = pop();
     // print('TODO: end mix, $name');
     checkEmpty();
 
     ClassScope s = scope;
     s.currentClass
       ..name = name
       ..isAbstract = modifiers & _abstract_flag != 0
       ..isMixinApplication = true
-      // ignore: strong_mode_down_cast_composite
       ..annotations = metadata
-      // ignore: strong_mode_down_cast_composite
       ..typeParameters = typeVariables
       ..interfaces = interfaces;
     if (supertype != null) {
       s.currentClass.supertype = supertype;
     } else {
       s.currentClass.hasNoSupertype = isCoreLibrary && name == 'Object';
     }
     scope = scope.parent;
     topScope.unit.classes.add(s.currentClass);
 
     _addNameIfPublic(name, ReferenceKind.classOrEnum, typeVariables.length);
   }
 
   void endOptionalFormalParameters(
       int count, Token beginToken, Token endToken) {
     debugEvent("OptionalFormalParameters");
     push(popList(count));
   }
 
   void endPart(Token partKeyword, Token semicolon) {
     debugEvent("Part");
     String uri = pop();
-    // ignore: strong_mode_down_cast_composite
     List<UnlinkedExpr> metadata = pop();
     topScope.unit.parts.add(new UnlinkedPartBuilder(annotations: metadata));
     topScope.publicNamespace.parts.add(uri);
     checkEmpty();
   }
 
   void endPartOf(Token partKeyword, Token semicolon, bool hasName) {
     debugEvent("endPartOf");
     String name = pop();
     pop(); // metadata
     topScope.unit.isPartOf = true;
     if (name == 'dart.core') isCoreLibrary = true;
   }
 
   void endRedirectingFactoryBody(Token beginToken, Token endToken) {
     debugEvent("RedirectingFactoryBody");
     pop(); // Discard ConstructorReferenceBuilder.
   }
 
   void endShow(_) {
-    // ignore: strong_mode_down_cast_composite
     push(new UnlinkedCombinatorBuilder(shows: pop()));
   }
 
   void endTopLevelFields(int count, Token beginToken, Token endToken) {
     debugEvent("endTopLevelFields");
     _endFields(count, topScope.unit.variables, true);
     checkEmpty();
   }
 
   void endTopLevelMethod(Token beginToken, Token getOrSet, Token endToken) {
@@ skipping 14 matching lines @@
           : (getOrSet == 'set'
               ? UnlinkedExecutableKind.setter
               : UnlinkedExecutableKind.functionOrMethod),
       isExternal: modifiers & _external_flag != 0,
       isAbstract: modifiers & _abstract_flag != 0,
       isAsynchronous: asyncModifier & _async_flag != 0,
       isGenerator: asyncModifier & _star_flag != 0,
       isStatic: modifiers & _static_flag != 0,
       typeParameters: [], // TODO
       returnType: returnType,
-      // ignore: strong_mode_down_cast_composite
       parameters: formals,
-      // ignore: strong_mode_down_cast_composite
       annotations: metadata,
       inferredReturnTypeSlot: null, // not needed for top-levels
       // skip body.
     ));
 
     String normalizedName = getOrSet == 'set' ? '$name=' : name;
     _addNameIfPublic(
         normalizedName,
         getOrSet != null
             ? ReferenceKind.topLevelPropertyAccessor
@@ skipping 92 matching lines @@
     push("$receiver.$name");
   }
 
   void handleStringPart(token) {
     debugEvent("handleStringPart");
     push(token.lexeme.substring(1, token.lexeme.length - 1));
   }
 
   void handleType(Token beginToken, Token endToken) {
     debugEvent("Type");
-    // ignore: strong_mode_down_cast_composite
     List<EntityRef> arguments = pop();
     String name = pop();
 
     var type;
     if (name.contains('.')) {
       var parts = name.split('.');
       for (var p in parts) {
         type = type == null
             ? new LazyEntityRef(p, scope)
             : new NestedLazyEntityRef(type, p, scope);
@@ skipping 38 matching lines @@
   /// Add `name` and, if requested, `name=` to the public namespace.
   void _addPropertyName(String name, {bool includeSetter: false}) {
     _addName(name, ReferenceKind.topLevelPropertyAccessor);
     if (includeSetter) {
       _addName('$name=', ReferenceKind.topLevelPropertyAccessor);
     }
   }
 
   void _endFields(int count, List result, bool isTopLevel) {
     debugEvent('EndFields: $count $isTopLevel');
-    // ignore: strong_mode_down_cast_composite
     List<_InitializedName> fields = popList(count);
     EntityRef type = pop();
     int modifiers = pop();
     List metadata = pop();
 
     bool isStatic = modifiers & _static_flag != 0;
     bool isFinal = modifiers & _final_flag != 0;
     bool isConst = modifiers & _const_flag != 0;
     bool isInstance = !isStatic && !isTopLevel;
     for (var field in fields) {
       var name = field.name;
       var initializer = field.initializer;
       bool needsPropagatedType = initializer != null && (isFinal || isConst);
       bool needsInferredType =
           type == null && (initializer != null || isInstance);
       result.add(new UnlinkedVariableBuilder(
           isFinal: isFinal,
           isConst: isConst,
           isStatic: isStatic,
           name: name,
           type: type,
-          // ignore: strong_mode_down_cast_composite
           annotations: metadata,
           initializer: initializer,
           propagatedTypeSlot: slotIf(needsPropagatedType),
           inferredTypeSlot: slotIf(needsInferredType)));
 
       if (_isPrivate(name)) continue;
       if (isTopLevel) {
         _addPropertyName(name, includeSetter: !isFinal && !isConst);
       } else if (isStatic) {
         // Any reason setters are not added as well?
@@ skipping 12 matching lines @@
 }
 
 /// Internal representation of an initialized name.
 class _InitializedName {
   final String name;
   final UnlinkedExecutableBuilder initializer;
   _InitializedName(this.name, this.initializer);
 
   toString() => "II:" + (initializer != null ? "$name = $initializer" : name);
 }