Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2754983002: Composite sticky-positioned elements when they have composited descendants (Closed)
Patch Set: Address chrishtr comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
index 54502ea395576daf2d6d81f50626119604972e21..43d57ebe4b042d11783e96ac70281c34fc84ca55 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
@@ -195,11 +195,10 @@ static CompositingReasons SubtreeReasonsForCompositing(
// scroll-dependant fixed position elements with composited descendants for
// correctness - even if we lose LCD.
const bool ignore_lcd_text = true;
- if (layer->GetLayoutObject().Style()->GetPosition() == EPosition::kFixed &&
- compositing_reason_finder.RequiresCompositingForScrollDependentPosition(
+ if (compositing_reason_finder.RequiresCompositingForScrollDependentPosition(
layer, ignore_lcd_text)) {
subtree_reasons |=
- kCompositingReasonPositionFixedWithCompositedDescendants;
+ kCompositingReasonPositionFixedOrStickyWithCompositedDescendants;
}
}

Powered by Google App Engine
This is Rietveld 408576698