Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositingReasons.h

Issue 2754983002: Composite sticky-positioned elements when they have composited descendants (Closed)
Patch Set: Address chrishtr comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/CompositingReasons.h
diff --git a/third_party/WebKit/Source/platform/graphics/CompositingReasons.h b/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
index 4a45311865a7d9c6f91f873e7e30e4d19d026e2e..209b27e576c6d9a0769e37b51cf4fcafabc912b0 100644
--- a/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
+++ b/third_party/WebKit/Source/platform/graphics/CompositingReasons.h
@@ -63,8 +63,9 @@ const uint64_t kCompositingReasonReflectionOfCompositedParent = UINT64_C(1)
<< 28;
const uint64_t kCompositingReasonIsolateCompositedDescendants = UINT64_C(1)
<< 29;
-const uint64_t kCompositingReasonPositionFixedWithCompositedDescendants =
- UINT64_C(1) << 30;
+const uint64_t
+ kCompositingReasonPositionFixedOrStickyWithCompositedDescendants =
+ UINT64_C(1) << 30;
// The root layer is a special case. It may be forced to be a layer, but it also
// needs to be a layer if anything else in the subtree is composited.
@@ -130,7 +131,7 @@ const uint64_t kCompositingReasonComboCompositedDescendants =
kCompositingReasonBlendingWithCompositedDescendants |
kCompositingReasonReflectionWithCompositedDescendants |
kCompositingReasonClipsCompositingDescendants |
- kCompositingReasonPositionFixedWithCompositedDescendants;
+ kCompositingReasonPositionFixedOrStickyWithCompositedDescendants;
const uint64_t kCompositingReasonCombo3DDescendants =
kCompositingReasonPreserve3DWith3DDescendants |
@@ -158,7 +159,7 @@ const uint64_t kCompositingReasonComboReasonsThatRequireOwnBacking =
// 3d-transformed elements
// intersect.
kCompositingReasonBackdropFilter |
- kCompositingReasonPositionFixedWithCompositedDescendants;
+ kCompositingReasonPositionFixedOrStickyWithCompositedDescendants;
const uint64_t kCompositingReasonComboSquashableReasons =
kCompositingReasonOverlap | kCompositingReasonAssumedOverlap |

Powered by Google App Engine
This is Rietveld 408576698