Update cros network info bubble

Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the active and inactive state (shadow_controller.cc) instead of just the inactive state.
- make the contents of the info bubble a single, multi-line, selectable label. To be selectable, the bubble must be activatable. This is somewhat trickier because the system menu bubble wants to close itself whenever activation changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system bubble closes, when the user presses the back arrow, or when the user presses the (i) again.

BUG=676395, 341706
Review-Url: https://codereview.chromium.org/2754963002
Cr-Commit-Position: refs/heads/master@{#457760}
Committed: https://chromium.googlesource.com/chromium/src/+/0a0546417f0a60bb9822b5744de970adce5302fd

[Evan Stade, 2017-03-16 21:37:04]

Description was changed from

==========
WIP - update cros network info bubble

BUG=676395
==========

to

==========
Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the
active and inactive state (shadow_controller.cc) instead of just the inactive
state.
- make the contents of the info bubble a single, multi-line, selectable label.
To be selectable, the bubble must be activatable. This is somewhat trickier
because the system menu bubble wants to close itself whenever activation
changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*network info bubble closes as expected when the user mouses out, when the
system bubble closes, when the user presses the back arrow, or when the user
presses the (i) again.

BUG=676395
==========

[Evan Stade, 2017-03-16 21:38:31]

estade@chromium.org changed reviewers:
+ derat@chromium.org

[Evan Stade, 2017-03-16 21:38:36]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-03-16 21:39:03]

Description was changed from

==========
Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the
active and inactive state (shadow_controller.cc) instead of just the inactive
state.
- make the contents of the info bubble a single, multi-line, selectable label.
To be selectable, the bubble must be activatable. This is somewhat trickier
because the system menu bubble wants to close itself whenever activation
changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*network info bubble closes as expected when the user mouses out, when the
system bubble closes, when the user presses the back arrow, or when the user
presses the (i) again.

BUG=676395
==========

to

==========
Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the
active and inactive state (shadow_controller.cc) instead of just the inactive
state.
- make the contents of the info bubble a single, multi-line, selectable label.
To be selectable, the bubble must be activatable. This is somewhat trickier
because the system menu bubble wants to close itself whenever activation
changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system
bubble closes, when the user presses the back arrow, or when the user presses
the (i) again.

BUG=676395
==========

[commit-bot: I haz the power, 2017-03-16 21:39:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-03-16 21:40:46]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:40:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-03-16 21:46:09]

https://codereview.chromium.org/2754963002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_state_list_detailed_view.cc
(left):

https://codereview.chromium.org/2754963002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_state_list_detailed_view.cc:290:
ResetInfoBubble();
note that this wasn't really doing much of anything as very few views actually
trigger this function to be called.

[Evan Stade, 2017-03-16 21:47:15]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:47:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2017-03-16 21:58:51]

Description was changed from

==========
Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the
active and inactive state (shadow_controller.cc) instead of just the inactive
state.
- make the contents of the info bubble a single, multi-line, selectable label.
To be selectable, the bubble must be activatable. This is somewhat trickier
because the system menu bubble wants to close itself whenever activation
changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system
bubble closes, when the user presses the back arrow, or when the user presses
the (i) again.

BUG=676395
==========

to

==========
Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the
active and inactive state (shadow_controller.cc) instead of just the inactive
state.
- make the contents of the info bubble a single, multi-line, selectable label.
To be selectable, the bubble must be activatable. This is somewhat trickier
because the system menu bubble wants to close itself whenever activation
changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system
bubble closes, when the user presses the back arrow, or when the user presses
the (i) again.

BUG=676395,341706
==========

[Daniel Erat, 2017-03-16 21:59:14]

lgtm

added 341706 to the BUG= line since it sounds like this fixes that too, right?

[commit-bot: I haz the power, 2017-03-16 22:42:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 22:42:41]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-03-17 14:19:36]

On 2017/03/16 21:59:14, Daniel Erat wrote:
> lgtm
> 
> added 341706 to the BUG= line since it sounds like this fixes that too, right?

yes, thanks. That's the biggest win here.

[Evan Stade, 2017-03-17 14:20:02]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-03-17 14:20:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 14:25:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489760402918720,
"parent_rev": "54ee225d47dd22fe7d2a2cb75bde7d27d790bf49", "commit_rev":
"0a0546417f0a60bb9822b5744de970adce5302fd"}

[commit-bot: I haz the power, 2017-03-17 14:26:01]

Description was changed from

==========
Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the
active and inactive state (shadow_controller.cc) instead of just the inactive
state.
- make the contents of the info bubble a single, multi-line, selectable label.
To be selectable, the bubble must be activatable. This is somewhat trickier
because the system menu bubble wants to close itself whenever activation
changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system
bubble closes, when the user presses the back arrow, or when the user presses
the (i) again.

BUG=676395,341706
==========

to

==========
Update cros network info bubble

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the
active and inactive state (shadow_controller.cc) instead of just the inactive
state.
- make the contents of the info bubble a single, multi-line, selectable label.
To be selectable, the bubble must be activatable. This is somewhat trickier
because the system menu bubble wants to close itself whenever activation
changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system
bubble closes, when the user presses the back arrow, or when the user presses
the (i) again.

BUG=676395,341706

Review-Url: https://codereview.chromium.org/2754963002
Cr-Commit-Position: refs/heads/master@{#457760}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a0546417f0a60bb9822b5744de9...
==========

[commit-bot: I haz the power, 2017-03-17 14:26:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0a0546417f0a60bb9822b5744de9...