Files.app: Fix selection on creating new folder

chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index 04e60ce3e1b72c6b4a6a0497994ecec1ee35c188..8e82dea61df642354172288be420cde6c4e78c56 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -753,6 +753,18 @@ INSTANTIATE_TEST_CASE_P(
         TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatMultipleFileDrive")));
 
 INSTANTIATE_TEST_CASE_P(
+    CreateNewFolder,
+    FileManagerBrowserTest,
+    ::testing::Values(TestParameter(IN_GUEST_MODE,
+                                    "createNewFolderAfterSelectFile"),

[hirono, 2014/05/09 07:29:38]

Why don't you run the test with NOT_IN_GUEST_MODE?

[yoshiki, 2014/05/09 13:54:17]

I think, it should be enough only in NOT_IN_GUEST_MODE.

[hirono, 2014/05/12 02:28:27]

Yes, but line 758 is IN_GUEST_MODE. Is it intentional?

[yoshiki, 2014/05/13 09:40:57]

Sorry, IN_GUEST_MODE is correct. I think running in only IN_GUEST_MODE is
enough.

[hirono, 2014/05/13 10:16:29]

I agree with that one mode is enough here. And many users actually use
NOT_IN_GUEST_MODE, so I'm thinking the mode is better to test. WDYT?

[yoshiki, 2014/05/13 13:21:38]

I don't have a strong opinion and changes it into NOT_IN_GUEST_MODE as you
guided. Thanks.

+                      TestParameter(IN_GUEST_MODE,
+                                    "createNewFolderDownloads"),
+                      TestParameter(NOT_IN_GUEST_MODE,
+                                    "createNewFolderDownloads"),
+                      TestParameter(NOT_IN_GUEST_MODE,
+                                    "createNewFolderDrive")));
+
+INSTANTIATE_TEST_CASE_P(
     KeyboardOperations,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(IN_GUEST_MODE, "keyboardDeleteDownloads"),
@@ -763,12 +775,6 @@ INSTANTIATE_TEST_CASE_P(
                       TestParameter(NOT_IN_GUEST_MODE, "keyboardCopyDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE, "keyboardCopyDrive"),
                       TestParameter(IN_GUEST_MODE,
-                                    "createNewFolderDownloads"),
-                      TestParameter(NOT_IN_GUEST_MODE,
-                                    "createNewFolderDownloads"),
-                      TestParameter(NOT_IN_GUEST_MODE,
-                                    "createNewFolderDrive"),
-                      TestParameter(IN_GUEST_MODE,
                                     "renameFileDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE,
                                     "renameFileDownloads"),