Files.app: Fix selection on creating new folder

chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Browser test for basic Chrome OS file manager functionality:
 //  - The file list is updated when a file is added externally to the Downloads
 //    folder.
 //  - Selecting a file and copy-pasting it with the keyboard copies the file.
 //  - Selecting a file and pressing delete deletes it.
 
@@ skipping 735 matching lines @@
         TestParameter(IN_GUEST_MODE, "audioOpenDownloads"),
         TestParameter(NOT_IN_GUEST_MODE, "audioOpenDownloads"),
         TestParameter(NOT_IN_GUEST_MODE, "audioOpenDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "audioAutoAdvanceDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "audioRepeatSingleFileDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatSingleFileDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "audioRepeatMultipleFileDrive"),
         TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatMultipleFileDrive")));
 
 INSTANTIATE_TEST_CASE_P(
+    CreateNewFolder,
+    FileManagerBrowserTest,
+    ::testing::Values(TestParameter(IN_GUEST_MODE,
+                                    "createNewFolderAfterSelectFile"),

[hirono, 2014/05/09 07:29:38]

Why don't you run the test with NOT_IN_GUEST_MODE?

[yoshiki, 2014/05/09 13:54:17]

I think, it should be enough only in NOT_IN_GUEST_MODE.

[hirono, 2014/05/12 02:28:27]

Yes, but line 758 is IN_GUEST_MODE. Is it intentional?

[yoshiki, 2014/05/13 09:40:57]

Sorry, IN_GUEST_MODE is correct. I think running in only IN_GUEST_MODE is
enough.

[hirono, 2014/05/13 10:16:29]

I agree with that one mode is enough here. And many users actually use
NOT_IN_GUEST_MODE, so I'm thinking the mode is better to test. WDYT?

[yoshiki, 2014/05/13 13:21:38]

I don't have a strong opinion and changes it into NOT_IN_GUEST_MODE as you
guided. Thanks.

+                      TestParameter(IN_GUEST_MODE,
+                                    "createNewFolderDownloads"),
+                      TestParameter(NOT_IN_GUEST_MODE,
+                                    "createNewFolderDownloads"),
+                      TestParameter(NOT_IN_GUEST_MODE,
+                                    "createNewFolderDrive")));
+
+INSTANTIATE_TEST_CASE_P(
     KeyboardOperations,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(IN_GUEST_MODE, "keyboardDeleteDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE,
                                     "keyboardDeleteDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE, "keyboardDeleteDrive"),
                       TestParameter(IN_GUEST_MODE, "keyboardCopyDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE, "keyboardCopyDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE, "keyboardCopyDrive"),
                       TestParameter(IN_GUEST_MODE,
-                                    "createNewFolderDownloads"),
-                      TestParameter(NOT_IN_GUEST_MODE,
-                                    "createNewFolderDownloads"),
-                      TestParameter(NOT_IN_GUEST_MODE,
-                                    "createNewFolderDrive"),
-                      TestParameter(IN_GUEST_MODE,
                                     "renameFileDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE,
                                     "renameFileDownloads"),
                       TestParameter(NOT_IN_GUEST_MODE,
                                     "renameFileDrive")));
 
 INSTANTIATE_TEST_CASE_P(
     DriveSpecific,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "openSidebarRecent"),
@@ skipping 275 matching lines @@
   // (bob and charlie) are added in the test. Thus the existing test verifies
   // that the feature is effectively working with lastly logged in users.
   AddExtraUsersForStressTesting();
 
   set_test_case_name("multiProfileVisitDesktopMenu");
   StartTest();
 }
 
 }  // namespace
 }  // namespace file_manager