|
|
Chromium Code Reviews
DescriptionClient config and QUIC transaction integration tests
BUG=680570, 680564
Review-Url: https://codereview.chromium.org/2754803004
Cr-Commit-Position: refs/heads/master@{#457892}
Committed: https://chromium.googlesource.com/chromium/src/+/e9ee3d63b09c9ef3f9dafc84bf7cfa83c89203fc
Patch Set 1 : ps #
Messages
Total messages: 18 (8 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Client config integration test BUG= ========== to ========== Client config and QUIC transaction integration tests BUG=680570, 680564 ==========
tbansal@chromium.org changed reviewers: + ryansturm@chromium.org
ryansturm: ptal. Thanks.
tbansal@chromium.org changed reviewers: + megjablon@chromium.org - ryansturm@chromium.org
megjablon: ptal. Thanks.
tbansal@chromium.org changed reviewers: + robertogden@chromium.org
ptal. Thanks.
lgtm
The bugs say these should be in client_config.py and quic.py. Any reason they're in smoke instead?
On 2017/03/17 21:38:07, megjablon wrote: > The bugs say these should be in client_config.py and quic.py. Any reason they're > in smoke instead? The file names were just made up by me. But I defer to whatever you think is cleanest
lgtm
On 2017/03/17 21:45:51, megjablon wrote: > lgtm I do not have any preference on the filename. I did not see that the filename was specified in the bug. I think once we have some experience with buildbots, we can probably rearrange? Both client config and quic have only one test. So, for now it is probably OK to keep them there instead of creating a separate file.
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489788118433600,
"parent_rev": "19f804ba738ca0e6133bc19d7ade010208c9a8db", "commit_rev":
"e9ee3d63b09c9ef3f9dafc84bf7cfa83c89203fc"}
Message was sent while issue was closed.
Description was changed from ========== Client config and QUIC transaction integration tests BUG=680570, 680564 ========== to ========== Client config and QUIC transaction integration tests BUG=680570, 680564 Review-Url: https://codereview.chromium.org/2754803004 Cr-Commit-Position: refs/heads/master@{#457892} Committed: https://chromium.googlesource.com/chromium/src/+/e9ee3d63b09c9ef3f9dafc84bf7c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e9ee3d63b09c9ef3f9dafc84bf7c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
