Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2754803004: Client config and QUIC transaction integration tests (Closed)

Created:
3 years, 9 months ago by tbansal1
Modified:
3 years, 9 months ago
Reviewers:
Robert Ogden, megjablon
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Client config and QUIC transaction integration tests BUG=680570, 680564 Review-Url: https://codereview.chromium.org/2754803004 Cr-Commit-Position: refs/heads/master@{#457892} Committed: https://chromium.googlesource.com/chromium/src/+/e9ee3d63b09c9ef3f9dafc84bf7cfa83c89203fc

Patch Set 1 : ps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M tools/chrome_proxy/webdriver/smoke.py View 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 9 months ago (2017-03-17 00:13:11 UTC) #4
tbansal1
megjablon: ptal. Thanks.
3 years, 9 months ago (2017-03-17 17:17:24 UTC) #6
tbansal1
ptal. Thanks.
3 years, 9 months ago (2017-03-17 18:14:56 UTC) #8
Robert Ogden
lgtm
3 years, 9 months ago (2017-03-17 18:35:40 UTC) #9
megjablon
The bugs say these should be in client_config.py and quic.py. Any reason they're in smoke ...
3 years, 9 months ago (2017-03-17 21:38:07 UTC) #10
Robert Ogden
On 2017/03/17 21:38:07, megjablon wrote: > The bugs say these should be in client_config.py and ...
3 years, 9 months ago (2017-03-17 21:42:03 UTC) #11
megjablon
lgtm
3 years, 9 months ago (2017-03-17 21:45:51 UTC) #12
tbansal1
On 2017/03/17 21:45:51, megjablon wrote: > lgtm I do not have any preference on the ...
3 years, 9 months ago (2017-03-17 22:01:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754803004/20001
3 years, 9 months ago (2017-03-17 22:04:15 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 22:22:38 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e9ee3d63b09c9ef3f9dafc84bf7c...

Powered by Google App Engine
This is Rietveld 408576698