Reading List iOS: Handle multiple pages.

Reading List iOS: Handle multiple pages.

Set the origin_url when creating the distiller.
Only report mime_type and navigation on main page.

BUG=702113
Review-Url: https://codereview.chromium.org/2754803003
Cr-Commit-Position: refs/heads/master@{#458698}
Committed: https://chromium.googlesource.com/chromium/src/+/6caf2deb98f1cf37f5268eed152475016023a95a

[Olivier, 2017-03-17 15:48:37]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 15:48:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Olivier, 2017-03-17 15:56:13]

Description was changed from

==========
Reaidng List iOS: Handle multiple pages.


BUG=
==========

to

==========
Reading List iOS: Handle multiple pages.

Set the origin_url when creating the distiller.
Only report mime_type and navigation on main page.

BUG=702113
==========

[Olivier, 2017-03-17 15:56:28]

olivierrobin@chromium.org changed reviewers:
+ gambard@chromium.org, wychen@chromium.org

[commit-bot: I haz the power, 2017-03-17 15:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 15:58:50]

Dry run: This issue passed the CQ dry run.

[gambard, 2017-03-17 16:14:16]

https://codereview.chromium.org/2754803003/diff/20001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_distiller_page.h (right):

https://codereview.chromium.org/2754803003/diff/20001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_distiller_page.h:59: void
DistillPageImpl(const GURL& url, const std::string& script) override;
Are you sure this won't be called for another "origin" page?

[Olivier, 2017-03-17 16:32:42]

https://codereview.chromium.org/2754803003/diff/20001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_distiller_page.h (right):

https://codereview.chromium.org/2754803003/diff/20001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_distiller_page.h:59: void
DistillPageImpl(const GURL& url, const std::string& script) override;
On 2017/03/17 16:14:16, gambard wrote:
> Are you sure this won't be called for another "origin" page?

Discussed offline.
Yes, we control this code.

[wychen, 2017-03-21 06:42:29]

lgtm

[gambard, 2017-03-21 07:57:44]

lgtm, sorry for the delay

[Olivier, 2017-03-21 10:01:56]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-03-21 10:02:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 10:08:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 10:08:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Olivier, 2017-03-21 12:44:41]

olivierrobin@chromium.org changed reviewers:
+ noyau@chromium.org

[Olivier, 2017-03-21 12:44:42]

+ noyau for ownership

[noyau (Ping after 24h), 2017-03-21 14:14:05]

lgtm

[noyau (Ping after 24h), 2017-03-21 14:15:08]

Any tests to add to check this?

[Olivier, 2017-03-22 08:52:22]

On 2017/03/21 14:15:08, noyau wrote:
> Any tests to add to check this?

I will figure out how to add tests for this, but multipage is more tested in DOM
distiller.

[Olivier, 2017-03-22 08:52:35]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-03-22 08:52:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 09:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 09:01:11]

Failed to apply patch for
ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h:
While running git apply --index -p1;
  error: patch failed:
ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h:28
  error: ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h:
patch does not apply

Patch:      
ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h
Index: ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h
diff --git
a/ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h
b/ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h
index
71acfca6cdc0cad39d76a650baea2036c5b80d63..1fe299672d46d18e3d951ce686c0cfa0343e1b32
100644
--- a/ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h
+++ b/ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h
@@ -8,6 +8,7 @@
 #include <memory>
 
 #include "base/macros.h"
+#include "url/gurl.h"
 
 namespace web {
 class BrowserState;
@@ -28,8 +29,10 @@ class ReadingListDistillerPageFactory {
   explicit ReadingListDistillerPageFactory(web::BrowserState* browser_state);
   virtual ~ReadingListDistillerPageFactory();
 
-  // Creates a ReadingListDistillerPage.
+  // Creates a ReadingListDistillerPage to distill |url|.
+  // Information about page will be reported to |delegate|.
   std::unique_ptr<ReadingListDistillerPage> CreateReadingListDistillerPage(
+      const GURL& url,
       ReadingListDistillerPageDelegate* delegate) const;
 
  private:

[Olivier, 2017-03-22 09:13:49]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2017-03-22 09:13:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
gambard@chromium.org, noyau@chromium.org, wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/2754803003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-22 09:14:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 09:28:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490174029942450,
"parent_rev": "330dfd209e7929ff3ea6b2045485732478969bfa", "commit_rev":
"6caf2deb98f1cf37f5268eed152475016023a95a"}

[commit-bot: I haz the power, 2017-03-22 09:28:42]

Description was changed from

==========
Reading List iOS: Handle multiple pages.

Set the origin_url when creating the distiller.
Only report mime_type and navigation on main page.

BUG=702113
==========

to

==========
Reading List iOS: Handle multiple pages.

Set the origin_url when creating the distiller.
Only report mime_type and navigation on main page.

BUG=702113

Review-Url: https://codereview.chromium.org/2754803003
Cr-Commit-Position: refs/heads/master@{#458698}
Committed:
https://chromium.googlesource.com/chromium/src/+/6caf2deb98f1cf37f5268eed1524...
==========

[commit-bot: I haz the power, 2017-03-22 09:28:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6caf2deb98f1cf37f5268eed1524...