Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2754793003: Simplify a base::Callback rebinding in web_view_permission_helper.cc (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel, lazyboy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify a base::Callback rebinding in web_view_permission_helper.cc Taking a method pointer to Callback::Run is problematic for upcoming refactoring of it. Review-Url: https://codereview.chromium.org/2754793003 Cr-Commit-Position: refs/heads/master@{#457754} Committed: https://chromium.googlesource.com/chromium/src/+/f4ae1808d7df0ae6d41ee04511cb289b5faa6d25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M extensions/browser/guest_view/web_view/web_view_permission_helper.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tzik
PTAL
3 years, 9 months ago (2017-03-17 05:18:44 UTC) #5
Xi Han
lgtm
3 years, 9 months ago (2017-03-17 13:37:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754793003/1
3 years, 9 months ago (2017-03-17 13:54:26 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 13:59:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4ae1808d7df0ae6d41ee04511cb...

Powered by Google App Engine
This is Rietveld 408576698