Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2754793002: Fix a few hints. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose, danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/string_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 9 months ago (2017-03-16 09:39:18 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-16 09:40:18 UTC) #3
ahe
Committed patchset #1 (id:1) manually as 87d932147dd68911fa4310ca5c35df058f1fc505 (presubmit successful).
3 years, 9 months ago (2017-03-16 09:48:22 UTC) #5
danrubel
3 years, 9 months ago (2017-03-16 12:19:19 UTC) #6
Message was sent while issue was closed.
LGTM. Thank you!

Powered by Google App Engine
This is Rietveld 408576698