Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2752823003: Remove unnecessary casts. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/kernel/lib/transformations/closure/converter.dart View 1 chunk +2 lines, -2 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
https://codereview.chromium.org/2752823003/diff/1/pkg/kernel/lib/transformations/closure/converter.dart File pkg/kernel/lib/transformations/closure/converter.dart (right): https://codereview.chromium.org/2752823003/diff/1/pkg/kernel/lib/transformations/closure/converter.dart#newcode679 pkg/kernel/lib/transformations/closure/converter.dart:679: if (node is Class && node.name == closureClassName) { ...
3 years, 9 months ago (2017-03-16 09:37:09 UTC) #2
Dmitry Stefantsov
LGTM https://codereview.chromium.org/2752823003/diff/1/pkg/kernel/lib/transformations/closure/converter.dart File pkg/kernel/lib/transformations/closure/converter.dart (right): https://codereview.chromium.org/2752823003/diff/1/pkg/kernel/lib/transformations/closure/converter.dart#newcode679 pkg/kernel/lib/transformations/closure/converter.dart:679: if (node is Class && node.name == closureClassName) ...
3 years, 9 months ago (2017-03-16 09:42:10 UTC) #3
ahe
3 years, 9 months ago (2017-03-16 09:49:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d83d616015212ef652f4cc26c7cc4f58565fa97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698