Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2754733002: Closure: remove pending_compiler_externs.js (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure: remove pending_compiler_externs.js The only thing they provided is already inside of compiler.jar's externs.zip/browser/html5.js at this point (HTMLImportElement#import). R=tbreisacher@chromium.org BUG=697353 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2754733002 Cr-Commit-Position: refs/heads/master@{#457345} Committed: https://chromium.googlesource.com/chromium/src/+/262914424bb02c970d5593c9f66d8f2657d022ff

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -24 lines) Patch
M third_party/closure_compiler/externs/compiled_resources2.gyp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/closure_compiler/externs/pending_compiler_externs.js View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/closure_compiler/tools/create_include_gyp.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/compiled_resources.gyp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M ui/webui/resources/js/compiled_resources2.gyp View 1 2 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Dan Beam
3 years, 9 months ago (2017-03-15 22:08:34 UTC) #2
Tyler Breisacher (Chromium)
I didn't even know this file existed. It makes me a tiny bit sad. lgtm.
3 years, 9 months ago (2017-03-15 22:12:08 UTC) #5
Dan Beam
ok, so, i figured out that just adding com.google.javascript:closure-compiler-externs to the `mvn install` command in ...
3 years, 9 months ago (2017-03-16 01:36:29 UTC) #11
Dan Beam
ok, repurposed this to remove that sad little externs file
3 years, 9 months ago (2017-03-16 02:42:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754733002/40001
3 years, 9 months ago (2017-03-16 02:42:32 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 04:05:21 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/262914424bb02c970d5593c9f66d...

Powered by Google App Engine
This is Rietveld 408576698