Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2754663003: DCLayerOverlay should damage entire frame on resize. (Closed)

Created:
3 years, 9 months ago by jbauman
Modified:
3 years, 9 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DCLayerOverlay should damage entire frame on resize. The output surface (and SetDamageRectCHROMIUM) requires that the entire output surface be redrawn on resize. So don't attempt to subtract out damage in this case. Also, the damage rect must always be contained within the output rect, so clip it to that. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2754663003 Cr-Commit-Position: refs/heads/master@{#457632} Committed: https://chromium.googlesource.com/chromium/src/+/8f0264a9eb0620b67b746a44b5856eea61245f77

Patch Set 1 #

Patch Set 2 : fix name #

Patch Set 3 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -24 lines) Patch
M cc/output/dc_layer_overlay.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/dc_layer_overlay.cc View 1 5 chunks +8 lines, -4 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 1 chunk +28 lines, -20 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
jbauman
3 years, 9 months ago (2017-03-16 23:57:21 UTC) #15
ccameron
lgtm
3 years, 9 months ago (2017-03-17 00:02:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754663003/40001
3 years, 9 months ago (2017-03-17 00:18:01 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 00:48:05 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f0264a9eb0620b67b746a44b585...

Powered by Google App Engine
This is Rietveld 408576698