Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

After any alphabet is entered in 'Search box',  Textfield::DoInsertChar is
called and it first updates the cursor visibility by calling UpdateAfterChange
then it calls OnAfterUserAction to update the textfield focus and which may
change the cursor visibility. If the cursor visibility is changed in
OnAfterUserAction, the text cursor will not being updated again. The previous
CL (https://codereview.chromium.org/2728433002/) exposed this wrong order of
updating.

TEST=TextfieldTest.CursorVisibilityChangeAfterInserting

BUG=698172
Review-Url: https://codereview.chromium.org/2729133005
Cr-Commit-Position: refs/heads/master@{#456444}
(cherry picked from commit c57eaf40e82246d8acb9f58a350ef1a619cb19b1)

Review-Url: https://codereview.chromium.org/2754633002 .
Cr-Commit-Position: refs/branch-heads/3029@{#200}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/ddae604aa75d462f6cfde9bed6744a2bc113bed2

[sadrul, 2017-03-15 06:34:53]

Description was changed from

==========
Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

After any alphabet is entered in 'Search box',  Textfield::DoInsertChar is
called and it first updates the cursor visibility by calling UpdateAfterChange
then it calls OnAfterUserAction to update the textfield focus and which may
change the cursor visibility. If the cursor visibility is changed in
OnAfterUserAction, the text cursor will not being updated again. The previous
CL (https://codereview.chromium.org/2728433002/) exposed this wrong order of
updating.

TEST=TextfieldTest.CursorVisibilityChangeAfterInserting

BUG=698172

Review-Url: https://codereview.chromium.org/2729133005
Cr-Commit-Position: refs/heads/master@{#456444}
(cherry picked from commit c57eaf40e82246d8acb9f58a350ef1a619cb19b1)
==========

to

==========
Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

After any alphabet is entered in 'Search box',  Textfield::DoInsertChar is
called and it first updates the cursor visibility by calling UpdateAfterChange
then it calls OnAfterUserAction to update the textfield focus and which may
change the cursor visibility. If the cursor visibility is changed in
OnAfterUserAction, the text cursor will not being updated again. The previous
CL (https://codereview.chromium.org/2728433002/) exposed this wrong order of
updating.

TEST=TextfieldTest.CursorVisibilityChangeAfterInserting

BUG=698172

Review-Url: https://codereview.chromium.org/2729133005
Cr-Commit-Position: refs/heads/master@{#456444}
(cherry picked from commit c57eaf40e82246d8acb9f58a350ef1a619cb19b1)

Review-Url: https://codereview.chromium.org/2754633002 .
Cr-Commit-Position: refs/branch-heads/3029@{#200}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/ddae604aa75d462f6cfde9bed674...
==========

[sadrul, 2017-03-15 06:34:54]

Committed patchset #1 (id:1) manually as
ddae604aa75d462f6cfde9bed6744a2bc113bed2.