Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issue 2754593003: Renames ui::mojom::Accelerator to ui::mojom::WmAccelerator (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames ui::mojom::Accelerator to ui::mojom::WmAccelerator I'm doing this as I want to create a mojom for ui::Accelerator, and this name conflicts with it. BUG=701815 TEST=covered by tests R=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2754593003 Cr-Commit-Position: refs/heads/master@{#457174} Committed: https://chromium.googlesource.com/chromium/src/+/7bb882c8557f2b9e77f2c283a676478e11d30235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M ash/mus/accelerators/accelerator_controller_registrar.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/accelerators/accelerator_controller_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/common/accelerator_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/common/accelerator_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/ui/public/interfaces/window_manager.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 9 months ago (2017-03-15 18:29:46 UTC) #1
Tom Sepez
RS LGTM stamp.
3 years, 9 months ago (2017-03-15 19:12:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754593003/1
3 years, 9 months ago (2017-03-15 19:22:05 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 19:51:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bb882c8557f2b9e77f2c283a676...

Powered by Google App Engine
This is Rietveld 408576698