Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2754573002: Revert of Collect type profile for DevTools. (Closed)

Created:
3 years, 9 months ago by Franzi
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Collect type profile for DevTools. (patchset #40 id:750001 of https://codereview.chromium.org/2707873002/ ) Reason for revert: gcc bot is now flaky https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/11863 Original issue's description: > Collect type profile for DevTools > > Collect type information for JavaScript variables and display it > in Chrome DevTools. > Design Doc: https://docs.google.com/a/google.com/document/d/1O1uepXZXBI6IwiawTrYC3ohhiNgzkyTdjn3R8ysbYgk/edit?usp=sharing > > When debugging JavaScript, it’s helpful to know the type of > a variable, parameter, and return values. JavaScript is > dynamically typed, and for complex > source code it’s often hard to infer types. With type profiling, we > can provide type information to JavaScript developers. > > This CL is a proof of concept. It collects type profile for > assignments and simply prints the types to stdout. > > The output looks something like this: > > #my_var1 > #Object > #number > #string > #number > #undefined > #string > #Object > #Object > > > We use an extra slot in the feedback vector of assignments to > carry the list of types for that assignment. The extra slot is > only added when the flag --type-profile is given. > > > Missing work: > * Collect data for parameters and return values (currently only assignments). > * Remove duplicates from the list of collected types and use a common base class. > * Add line numbers or source position instead of the variable name. > > > > BUG=v8:5935 > > Review-Url: https://codereview.chromium.org/2707873002 > Cr-Original-Commit-Position: refs/heads/master@{#43791} > Committed: https://chromium.googlesource.com/v8/v8/+/0332bebde99d0f9a5a8326382f5f37cc26224ae0 > Review-Url: https://codereview.chromium.org/2707873002 > Cr-Commit-Position: refs/heads/master@{#43804} > Committed: https://chromium.googlesource.com/v8/v8/+/6cf880f4b84c533d4bb139d33c1369e309d1c579 TBR=yangguo@chromium.org,mvstanton@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5935 Review-Url: https://codereview.chromium.org/2754573002 Cr-Commit-Position: refs/heads/master@{#43805} Committed: https://chromium.googlesource.com/v8/v8/+/14d0930d40d179cd81bffe601ec3ce9440643764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3342 lines) Patch
M src/ast/ast.h View 2 chunks +1 line, -11 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/ast/ast-numbering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast/ast-numbering.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -15 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/feedback-vector.h View 4 chunks +0 lines, -32 lines 0 comments Download
M src/feedback-vector.cc View 5 chunks +1 line, -61 lines 0 comments Download
M src/feedback-vector-inl.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 4 chunks +0 lines, -31 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D test/inspector/type-profile/collect-type-profile.js View 1 chunk +0 lines, -38 lines 0 comments Download
D test/inspector/type-profile/collect-type-profile-array-splice.js View 1 chunk +0 lines, -440 lines 0 comments Download
D test/inspector/type-profile/collect-type-profile-array-splice-expected.txt View 1 chunk +0 lines, -1711 lines 0 comments Download
D test/inspector/type-profile/collect-type-profile-expected.txt View 1 chunk +0 lines, -902 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Franzi
Created Revert of Collect type profile for DevTools.
3 years, 9 months ago (2017-03-14 21:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754573002/1
3 years, 9 months ago (2017-03-14 21:32:24 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 21:32:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/14d0930d40d179cd81bffe601ec3ce94406...

Powered by Google App Engine
This is Rietveld 408576698