Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8386)

Unified Diff: chrome/test/data/webui/settings/basic_page_browsertest.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/basic_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/basic_page_browsertest.js b/chrome/test/data/webui/settings/basic_page_browsertest.js
index c0a186f0822caff15d5f540f23874267b8ae5a33..b81e5b2fd5c111ffb0eeb21c835741eb9188f61c 100644
--- a/chrome/test/data/webui/settings/basic_page_browsertest.js
+++ b/chrome/test/data/webui/settings/basic_page_browsertest.js
@@ -86,7 +86,7 @@ TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() {
});
test('basic pages', function() {
- var page = self.getPage('basic');
+ var page = self.basicPage;
var sections = ['appearance', 'onStartup', 'people', 'search'];
expectTrue(!!self.getSection(page, 'appearance'));
if (!cr.isChromeOS)
@@ -102,16 +102,14 @@ TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() {
});
test('scroll to section', function() {
+ var page = self.basicPage;
// Setting the page and section will cause a scrollToSection_.
settings.navigateTo(settings.Route.ON_STARTUP);
- var page = self.getPage('basic');
-
return new Promise(function(resolve, reject) {
// This test checks for a regression that occurred with scrollToSection_
// failing to find its host element.
var intervalId = window.setInterval(function() {
- var page = self.getPage('basic');
if (self.getSection(page, settings.getCurrentRoute().section)) {
window.clearInterval(intervalId);
resolve();
@@ -140,6 +138,7 @@ TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() {
});
test('scroll to section after exiting search', function() {
+ var page = self.basicPage;
var searchManager = new TestSearchManager();
settings.setSearchManagerForTesting(searchManager);
@@ -152,7 +151,6 @@ TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() {
/* dynamicParams */ null,
/* removeSearch */ true);
- var page = self.getPage('basic');
assertTrue(!!page);
// Should (after some time) be scrolled to the On Startup section.
@@ -167,7 +165,7 @@ TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() {
});
test('scroll to top before navigating to about', function() {
- var page = self.getPage('basic');
+ var page = self.basicPage;
// Set the viewport small to force the scrollbar to appear on ABOUT.
Polymer.dom().querySelector('settings-ui').style.height = '200px';

Powered by Google App Engine
This is Rietveld 408576698