Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: chrome/test/data/webui/settings/advanced_page_browsertest.js

Issue 2754563002: MD Settings: Lazy load the contents of the "advanced" settings. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome/test/data/webui/settings/basic_page_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/advanced_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/advanced_page_browsertest.js b/chrome/test/data/webui/settings/advanced_page_browsertest.js
index 39b85442f8bbde95a9c9cd7982c5bb5897e60618..52947f55da4a50e9af1e83a535e4ea2b72ead849 100644
--- a/chrome/test/data/webui/settings/advanced_page_browsertest.js
+++ b/chrome/test/data/webui/settings/advanced_page_browsertest.js
@@ -41,7 +41,7 @@ TEST_F('SettingsAdvancedPageBrowserTest', 'MAYBE_Load', function() {
});
test('advanced pages', function() {
- var page = self.getPage('basic');
+ var page = self.basicPage;
var sections = ['privacy', 'passwordsAndForms', 'languages', 'downloads',
'reset'];
if (cr.isChromeOS)
@@ -49,7 +49,7 @@ TEST_F('SettingsAdvancedPageBrowserTest', 'MAYBE_Load', function() {
for (var i = 0; i < sections.length; i++) {
var section = self.getSection(page, sections[i]);
- expectTrue(!!section);
+ assertTrue(!!section);
self.verifySubpagesHidden(section);
}
});
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome/test/data/webui/settings/basic_page_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698