Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2754543007: [WASM] Fix SIMD test that fails on ARM hardware. (Closed)

Created:
3 years, 9 months ago by bbudge
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[WASM] Fix SIMD test that fails on ARM hardware. - Change test to avoid adding denormalized numbers. This flushes to zero on ARM hardware when using Neon. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2754543007 Cr-Commit-Position: refs/heads/master@{#43864} Committed: https://chromium.googlesource.com/v8/v8/+/11f69171c39af1765ed59c03f905399fb76d1058

Patch Set 1 #

Patch Set 2 : Remove unnecessary iterations through test integer range. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M test/cctest/wasm/test-run-wasm-simd.cc View 1 11 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
bbudge
3 years, 9 months ago (2017-03-16 13:16:28 UTC) #4
Michael Achenbach
LGTM - stamp - not enough insights to give you a real review.
3 years, 9 months ago (2017-03-16 13:57:19 UTC) #10
bbudge
On 2017/03/16 13:57:19, Michael Achenbach wrote: > LGTM - stamp - not enough insights to ...
3 years, 9 months ago (2017-03-16 14:04:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754543007/20001
3 years, 9 months ago (2017-03-16 14:05:14 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 14:06:58 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/11f69171c39af1765ed59c03f905399fb76...

Powered by Google App Engine
This is Rietveld 408576698