Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionModifier.cpp

Issue 2754543004: Make Selection#modify() with word granularity not to skip punctuation (Closed)
Patch Set: 2017-03-26T01:40:34 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/SelectionModifier.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
index bf2ba83044befc9f73c99c7c71f5b6ea83320243..77e0ea5bcd11d3153e84f341429ba76e89b84bc2 100644
--- a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
@@ -147,28 +147,11 @@ VisiblePosition SelectionModifier::nextWordPositionForPlatform(
const VisiblePosition& originalPosition) {
VisiblePosition positionAfterCurrentWord = nextWordPosition(originalPosition);
- if (frame() &&
- frame()->editor().behavior().shouldSkipSpaceWhenMovingRight()) {
- // In order to skip spaces when moving right, we advance one
- // word further and then move one word back. Given the
- // semantics of previousWordPosition() this will put us at the
- // beginning of the word following.
- VisiblePosition positionAfterSpacingAndFollowingWord =
- nextWordPosition(positionAfterCurrentWord);
- if (positionAfterSpacingAndFollowingWord.isNotNull() &&
- positionAfterSpacingAndFollowingWord.deepEquivalent() !=
- positionAfterCurrentWord.deepEquivalent())
- positionAfterCurrentWord =
- previousWordPosition(positionAfterSpacingAndFollowingWord);
-
- bool movingBackwardsMovedPositionToStartOfCurrentWord =
- positionAfterCurrentWord.deepEquivalent() ==
- previousWordPosition(nextWordPosition(originalPosition))
- .deepEquivalent();
- if (movingBackwardsMovedPositionToStartOfCurrentWord)
- positionAfterCurrentWord = positionAfterSpacingAndFollowingWord;
- }
- return positionAfterCurrentWord;
+ if (!frame() ||
+ !frame()->editor().behavior().shouldSkipSpaceWhenMovingRight())
+ return positionAfterCurrentWord;
+ return createVisiblePosition(
+ skipWhitespace(positionAfterCurrentWord.deepEquivalent()));
}
static void adjustPositionForUserSelectAll(VisiblePosition& pos,
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698