third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html - Issue 2754543004: Make Selection#modify() with word granularity not to skip punctuation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html

Issue 2754543004: Make Selection#modify() with word granularity not to skip punctuation (Closed)

Patch Set: 2017-03-26T01:40:34 rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_word_002.html ('k') | third_party/WebKit/Source/core/editing/SelectionModifier.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html

diff --git a/third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html b/third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html

index 419262b52a00b2308071387a436acd322eabfe37..a9a13781f0672015f3b48efda6ce8d1c2be8bc29 100644

--- a/third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html

+++ b/third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html

@@ -15,11 +15,7 @@ test(() => assert_selection(

[

'<style>:first-letter{color:red;}</style>',

isMac ? '<div contenteditable> hello| world\'</div>'

- // The current non-Mac behavior is wrong. The correct expectation

- // should be 'hello |world'. A deeper reason is that Blink performs

- // backward word boundary searches to refine the final selection,

- // which doesn't work with first-letter (crbug.com/671104).

- : '<div contenteditable> hell|o world\'</div>'

+ : '<div contenteditable> hello |world\'</div>'

].join('')), 'Move forward by word');

test(() => assert_selection(

@@ -42,11 +38,7 @@ test(() => assert_selection(

[

'<style>:first-letter{color:red;}</style>',

isMac ? '<div contenteditable style="white-space:pre"> hello| world\'</div>'

- // The current non-Mac behavior is wrong. The correct expectation

- // should be 'hello |world'. A deeper reason is that Blink performs

- // backward word boundary searches to refine the final selection,

- // which doesn't work with first-letter (crbug.com/671104).

- : '<div contenteditable style="white-space:pre"> hell|o world\'</div>'

+ : '<div contenteditable style="white-space:pre"> hello |world\'</div>'

].join('')), 'Move forward by word with white-space:pre');

test(() => assert_selection(