Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2754533002: Make layout test media-audio-no-spurious-repaints.html pass (Closed)

Created:
3 years, 9 months ago by Stephen Chennney
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make layout test media-audio-no-spurious-repaints.html pass The number of invalidations has doubled in some cases. None of the changes I could see to the MediaControls shadow DOM seem to have caused this, so I cannot explain why the increase happened. But it has, and a couple more repaints doesn't seem like a major problem. TBR=wangxianzhu@chromium.org BUG=681471 Review-Url: https://codereview.chromium.org/2754533002 Cr-Commit-Position: refs/heads/master@{#456855} Committed: https://chromium.googlesource.com/chromium/src/+/d1df3ad6b707ae3bfff924a4674207e4772cd5fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/media/media-audio-no-spurious-repaints-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754533002/1
3 years, 9 months ago (2017-03-14 20:35:02 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:06:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1df3ad6b707ae3bfff924a46742...

Powered by Google App Engine
This is Rietveld 408576698